From: Jakub Kicinski <kuba@kernel.org>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shuah@kernel.org, petrm@nvidia.com, dw@davidwei.uk,
martin.lau@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, anupnewsmail@gmail.com
Subject: Re: [PATCH] selftests: drivers: net: fix name not defined
Date: Wed, 9 Oct 2024 19:32:56 -0700 [thread overview]
Message-ID: <20241009193256.2dd476c5@kernel.org> (raw)
In-Reply-To: <20241008220137.274660-1-alessandro.zanni87@gmail.com>
On Wed, 9 Oct 2024 00:01:33 +0200 Alessandro Zanni wrote:
> This fix solves this error, when calling kselftest with targets "drivers/net":
>
> File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__
> if e.errno == errno.ENOSPC:
> NameError: name 'errno' is not defined
>
> The module errno makes available standard error system symbols.
Can you say more about how you hit this error?
If it's just based on static analysis please mention that in the commit
message, and also mention that the problem doesn't happen in practice.
This will avoid the patch being backported unnecessarily.
We run all the tests in our CI, and the problem is not hit. But I agree
with you that the import is theoretically missing.
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-10 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 22:01 [PATCH] selftests: drivers: net: fix name not defined Alessandro Zanni
2024-10-10 2:32 ` Jakub Kicinski [this message]
2024-10-10 17:11 ` Alessandro Zanni
2024-10-10 7:40 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009193256.2dd476c5@kernel.org \
--to=kuba@kernel.org \
--cc=alessandro.zanni87@gmail.com \
--cc=anupnewsmail@gmail.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).