From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 0/2] net: do not rely on rtnl in netdev_nl_napi_get_xxx()
Date: Thu, 10 Oct 2024 08:55:59 -0700 [thread overview]
Message-ID: <20241010085559.36725e69@kernel.org> (raw)
In-Reply-To: <20241009232728.107604-1-edumazet@google.com>
On Wed, 9 Oct 2024 23:27:25 +0000 Eric Dumazet wrote:
> With upcoming per netns RTNL, rtnl use in netdev_nl_napi_get_doit()
> and netdev_nl_napi_get_dumpit() is a bit problematic.
>
> They can be changed to only rely on RCU.
Oh, you already posted this.
I was hoping we can start moving NAPIs and queues under dev->lock,
gradually move all local netdev state under that lock. RCU only
gets us so far when we have to cross reference objects (e.g. link
queue to NAPI). Even with NAPI SET not sure if RCU will work given
the writes have to happen into the instance and the "config struct".
prev parent reply other threads:[~2024-10-10 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 23:27 [PATCH net-next 0/2] net: do not rely on rtnl in netdev_nl_napi_get_xxx() Eric Dumazet
2024-10-09 23:27 ` [PATCH net-next 1/2] netdev-genl: do not use rtnl in netdev_nl_napi_get_doit() Eric Dumazet
2024-10-09 23:27 ` [PATCH net-next 2/2] netdev-genl: do not use rtnl in netdev_nl_napi_get_dumpit() Eric Dumazet
2024-10-10 15:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010085559.36725e69@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).