From: Furong Xu <0x1207@gmail.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
xfr@outlook.com, Furong Xu <0x1207@gmail.com>
Subject: [PATCH net-next v1] page_pool: check for dma_sync_size earlier
Date: Thu, 10 Oct 2024 19:40:19 +0800 [thread overview]
Message-ID: <20241010114019.1734573-1-0x1207@gmail.com> (raw)
Setting dma_sync_size to 0 is not illegal, and several drivers already did.
We can save a couple of function calls if check for dma_sync_size earlier.
Signed-off-by: Furong Xu <0x1207@gmail.com>
---
net/core/page_pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index a813d30d2135..fac52ba3f7c4 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -454,7 +454,7 @@ page_pool_dma_sync_for_device(const struct page_pool *pool,
netmem_ref netmem,
u32 dma_sync_size)
{
- if (pool->dma_sync && dma_dev_need_sync(pool->p.dev))
+ if (dma_sync_size && pool->dma_sync && dma_dev_need_sync(pool->p.dev))
__page_pool_dma_sync_for_device(pool, netmem, dma_sync_size);
}
--
2.34.1
next reply other threads:[~2024-10-10 11:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 11:40 Furong Xu [this message]
2024-10-10 11:53 ` [PATCH net-next v1] page_pool: check for dma_sync_size earlier Yunsheng Lin
2024-10-11 2:14 ` Furong Xu
2024-10-11 5:06 ` Ilias Apalodimas
2024-10-11 6:31 ` Furong Xu
2024-10-11 8:55 ` Yunsheng Lin
2024-10-11 9:26 ` Furong Xu
2024-10-11 15:49 ` Jakub Kicinski
2024-10-11 12:13 ` Ilias Apalodimas
2024-10-12 6:14 ` Yunsheng Lin
2024-10-14 6:35 ` Furong Xu
2024-10-14 12:38 ` Yunsheng Lin
2024-10-15 7:43 ` Ilias Apalodimas
2024-10-15 11:06 ` Yunsheng Lin
2024-10-15 13:25 ` Ilias Apalodimas
2024-10-16 2:32 ` Furong Xu
2024-10-16 9:09 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010114019.1734573-1-0x1207@gmail.com \
--to=0x1207@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).