From: Florian Westphal <fw@strlen.de>
To: Richard Weinberger <richard@sigma-star.at>
Cc: Richard Weinberger <richard@nod.at>,
upstream@sigma-star.at, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, kadlec@netfilter.org,
pablo@netfilter.org, rgb@redhat.com, paul@paul-moore.com,
upstream+net@sigma-star.at, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH] netfilter: Record uid and gid in xt_AUDIT
Date: Thu, 10 Oct 2024 15:48:27 +0200 [thread overview]
Message-ID: <20241010134827.GC30424@breakpoint.cc> (raw)
In-Reply-To: <3048359.FXINqZMJnI@somecomputer>
Richard Weinberger <richard@sigma-star.at> wrote:
> Am Mittwoch, 9. Oktober 2024, 23:33:45 CEST schrieb Florian Westphal:
> > There is no need to follow ->file backpointer anymore, see
> > 6acc5c2910689fc6ee181bf63085c5efff6a42bd and
> > 86741ec25462e4c8cdce6df2f41ead05568c7d5e,
> > "net: core: Add a UID field to struct sock.".
>
> Oh, neat!
>
> > I think we could streamline all the existing paths that fetch uid
> > from sock->file to not do that and use sock_net_uid() instead as well.
>
> Also xt_owner?
sk->sk_uid is already used e.g. for fib lookups so I think it makes
sense to be consistent, so, yes, xt_owner, nfqueue, nft_meta.c, all can
be converted.
next prev parent reply other threads:[~2024-10-10 13:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 20:32 [PATCH] netfilter: Record uid and gid in xt_AUDIT Richard Weinberger
2024-10-09 21:33 ` Florian Westphal
2024-10-09 21:46 ` Paul Moore
2024-10-09 22:34 ` Florian Westphal
2024-10-10 2:02 ` Paul Moore
2024-10-10 17:59 ` Florian Westphal
2024-10-10 19:13 ` Paul Moore
2024-10-10 6:27 ` Richard Weinberger
2024-10-10 13:48 ` Florian Westphal [this message]
2024-10-10 13:53 ` Jan Engelhardt
2024-10-10 20:09 ` Richard Weinberger
2024-10-11 1:27 ` Florian Westphal
2024-10-11 13:12 ` Richard Weinberger
2024-10-09 22:02 ` Paul Moore
2024-10-10 6:24 ` Richard Weinberger
2024-10-10 19:09 ` Paul Moore
2024-10-10 20:40 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010134827.GC30424@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=richard@nod.at \
--cc=richard@sigma-star.at \
--cc=upstream+net@sigma-star.at \
--cc=upstream@sigma-star.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).