netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] selftests: drivers: net: fix name not defined
@ 2024-10-10 18:30 Alessandro Zanni
  2024-10-11 23:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Alessandro Zanni @ 2024-10-10 18:30 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, shuah, petrm, sdf, martin.lau, dw
  Cc: Alessandro Zanni, netdev, linux-kselftest, linux-kernel, skhan,
	anupnewsmail

This fix solves this error, when calling kselftest with targets
"drivers/net":

File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__
  if e.errno == errno.ENOSPC:
NameError: name 'errno' is not defined

The error was found by running tests manually with the command:
make kselftest TARGETS="drivers/net"

The module errno makes available standard error system symbols.

Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---

Notes:
    v2: added how to run the test

 tools/testing/selftests/net/lib/py/nsim.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/lib/py/nsim.py b/tools/testing/selftests/net/lib/py/nsim.py
index f571a8b3139b..1a8cbe9acc48 100644
--- a/tools/testing/selftests/net/lib/py/nsim.py
+++ b/tools/testing/selftests/net/lib/py/nsim.py
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
+import errno
 import json
 import os
 import random
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] selftests: drivers: net: fix name not defined
  2024-10-10 18:30 [PATCH v2] selftests: drivers: net: fix name not defined Alessandro Zanni
@ 2024-10-11 23:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-11 23:10 UTC (permalink / raw)
  To: Alessandro Zanni
  Cc: davem, edumazet, kuba, pabeni, shuah, petrm, sdf, martin.lau, dw,
	netdev, linux-kselftest, linux-kernel, skhan, anupnewsmail

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 10 Oct 2024 20:30:30 +0200 you wrote:
> This fix solves this error, when calling kselftest with targets
> "drivers/net":
> 
> File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__
>   if e.errno == errno.ENOSPC:
> NameError: name 'errno' is not defined
> 
> [...]

Here is the summary with links:
  - [v2] selftests: drivers: net: fix name not defined
    https://git.kernel.org/netdev/net/c/174714f0e505

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-11 23:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-10 18:30 [PATCH v2] selftests: drivers: net: fix name not defined Alessandro Zanni
2024-10-11 23:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).