Re: [PATCH net-next] tools: ynl-gen: use names of constants in generated limits

[Joe Damato <jdamato@fastly.com>]

On Thu, Oct 10, 2024 at 08:12:48AM -0700, Jakub Kicinski wrote:
> YNL specs can use string expressions for limits, like s32-min
> or u16-max. We convert all of those into their numeric values
> when generating the code, which isn't always helpful. Try to
> retain the string representations in the output. Any sort of
> calculations still need the integers.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  net/core/netdev-genl-gen.c |  4 ++--
>  tools/net/ynl/ynl-gen-c.py | 36 +++++++++++++++++++++++-------------
>  2 files changed, 25 insertions(+), 15 deletions(-)

I rebased my per-NAPI changes on top of this commit and gave it a test
run and it generated this diff:

diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c
index 3692c8270c6b..21de7e10be16 100644
--- a/net/core/netdev-genl-gen.c
+++ b/net/core/netdev-genl-gen.c
@@ -23,7 +23,7 @@ static const struct netlink_range_validation netdev_a_page_pool_ifindex_range =
 };

 static const struct netlink_range_validation netdev_a_napi_defer_hard_irqs_range = {
-       .max    = 2147483647ULL,
+       .max    = S32_MAX,
 };

 /* Common nested types */
---

which is much nicer! I am not a python expert, but the code seems
reasonable to me and the generated output is a huge improvement (IMO).

Thanks for doing this.

Reviewed-by: Joe Damato <jdamato@fastly.com>