From: Jakub Kicinski <kuba@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
aleksander.lobakin@intel.com, johannes.berg@intel.com,
kory.maincent@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: vlan: Use vlan_prio instead of vlan_qos in mapping
Date: Fri, 11 Oct 2024 15:49:18 -0700 [thread overview]
Message-ID: <20241011154918.477cd612@kernel.org> (raw)
In-Reply-To: <20241009132302.2902-1-yajun.deng@linux.dev>
On Wed, 9 Oct 2024 21:23:02 +0800 Yajun Deng wrote:
> The vlan_qos member is used to save the vlan qos, but we only save the
> priority. Also, we will get the priority in vlan netlink and proc.
> So we can just save the vlan priority using vlan_prio.
>
> Defined VLAN_PRIO_MAX to limit the vlan priority to a maximum of 7.
> For flexibility, we introduced vlan_dev_get_egress_priority helper
> function.
The motivation is not clear, you don't explain how you tested, and
haven't added any selftests.
--
pw-bot: cr
prev parent reply other threads:[~2024-10-11 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 13:23 [PATCH net-next] net: vlan: Use vlan_prio instead of vlan_qos in mapping Yajun Deng
2024-10-11 22:49 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011154918.477cd612@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes.berg@intel.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).