netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rosen Penev" <rosenp@gmail.com>, "Andrew Lunn" <andrew@lunn.ch>,
	"Simon Horman" <horms@kernel.org>,
	"Shannon Nelson" <shannon.nelson@amd.com>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Breno Leitao" <leitao@debian.org>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Christian Marangi" <ansuelsmth@gmail.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv6 net-next 6/7] net: ibm: emac: generate random MAC if not found
Date: Fri, 11 Oct 2024 12:56:21 -0700	[thread overview]
Message-ID: <20241011195622.6349-7-rosenp@gmail.com> (raw)
In-Reply-To: <20241011195622.6349-1-rosenp@gmail.com>

On this Cisco MX60W, u-boot sets the local-mac-address property.
Unfortunately by default, the MAC is wrong and is actually located on a
UBI partition. Which means nvmem needs to be used to grab it.

In the case where that fails, EMAC fails to initialize instead of
generating a random MAC as many other drivers do.

Match behavior with other drivers to have a working ethernet interface.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/ibm/emac/core.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index b9ccaae61c48..faa483790b29 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -2937,9 +2937,12 @@ static int emac_init_config(struct emac_instance *dev)
 
 	/* Read MAC-address */
 	err = of_get_ethdev_address(np, dev->ndev);
-	if (err)
-		return dev_err_probe(&dev->ofdev->dev, err,
-				     "Can't get valid [local-]mac-address from OF !\n");
+	if (err == -EPROBE_DEFER)
+		return err;
+	if (err) {
+		dev_warn(&dev->ofdev->dev, "Can't get valid mac-address. Generating random.");
+		eth_hw_addr_random(dev->ndev);
+	}
 
 	/* IAHT and GAHT filter parameterization */
 	if (emac_has_feature(dev, EMAC_FTR_EMAC4SYNC)) {
-- 
2.47.0


  parent reply	other threads:[~2024-10-11 19:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 19:56 [PATCHv6 net-next 0/7] ibm: emac: more cleanups Rosen Penev
2024-10-11 19:56 ` [PATCHv6 net-next 1/7] net: ibm: emac: use netif_receive_skb_list Rosen Penev
2024-10-12 13:22   ` Simon Horman
2024-10-11 19:56 ` [PATCHv6 net-next 2/7] net: ibm: emac: remove custom init/exit functions Rosen Penev
2024-10-12 12:59   ` Simon Horman
2024-10-11 19:56 ` [PATCHv6 net-next 3/7] net: ibm: emac: use devm_platform_ioremap_resource Rosen Penev
2024-10-12 13:23   ` Simon Horman
2024-10-11 19:56 ` [PATCHv6 net-next 4/7] net: ibm: emac: use platform_get_irq Rosen Penev
2024-10-12 13:23   ` Simon Horman
2024-10-11 19:56 ` [PATCHv6 net-next 5/7] net: ibm: emac: use devm for mutex_init Rosen Penev
2024-10-12 12:43   ` Simon Horman
2024-10-11 19:56 ` Rosen Penev [this message]
2024-10-12 13:16   ` [PATCHv6 net-next 6/7] net: ibm: emac: generate random MAC if not found Simon Horman
2024-10-15 19:44     ` Rosen Penev
2024-10-16  7:36       ` Simon Horman
2024-10-11 19:56 ` [PATCHv6 net-next 7/7] net: ibm: emac: use of_find_matching_node Rosen Penev
2024-10-12 13:21   ` Simon Horman
2024-10-15 19:45     ` Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011195622.6349-7-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=shannon.nelson@amd.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).