From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH v1 net-next 10/11] can: gw: Use rtnl_register_many().
Date: Fri, 11 Oct 2024 15:05:49 -0700 [thread overview]
Message-ID: <20241011220550.46040-11-kuniyu@amazon.com> (raw)
In-Reply-To: <20241011220550.46040-1-kuniyu@amazon.com>
We will remove rtnl_register_module() in favour of rtnl_register_many().
rtnl_register_many() will unwind the previous successful registrations
on failure and simplify module error handling.
Let's use rtnl_register_many() instead.
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
---
net/can/gw.c | 26 +++++++++-----------------
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/net/can/gw.c b/net/can/gw.c
index 37528826935e..34d6b8c37b92 100644
--- a/net/can/gw.c
+++ b/net/can/gw.c
@@ -1265,6 +1265,12 @@ static struct pernet_operations cangw_pernet_ops = {
.exit_batch = cangw_pernet_exit_batch,
};
+static const struct rtnl_msg_handler cgw_rtnl_msg_handlers[] = {
+ {THIS_MODULE, PF_CAN, RTM_NEWROUTE, cgw_create_job, NULL, 0},
+ {THIS_MODULE, PF_CAN, RTM_DELROUTE, cgw_remove_job, NULL, 0},
+ {THIS_MODULE, PF_CAN, RTM_GETROUTE, NULL, cgw_dump_jobs, 0},
+};
+
static __init int cgw_module_init(void)
{
int ret;
@@ -1290,27 +1296,13 @@ static __init int cgw_module_init(void)
if (ret)
goto out_register_notifier;
- ret = rtnl_register_module(THIS_MODULE, PF_CAN, RTM_GETROUTE,
- NULL, cgw_dump_jobs, 0);
- if (ret)
- goto out_rtnl_register1;
-
- ret = rtnl_register_module(THIS_MODULE, PF_CAN, RTM_NEWROUTE,
- cgw_create_job, NULL, 0);
- if (ret)
- goto out_rtnl_register2;
- ret = rtnl_register_module(THIS_MODULE, PF_CAN, RTM_DELROUTE,
- cgw_remove_job, NULL, 0);
+ ret = rtnl_register_many(cgw_rtnl_msg_handlers);
if (ret)
- goto out_rtnl_register3;
+ goto out_rtnl_register;
return 0;
-out_rtnl_register3:
- rtnl_unregister(PF_CAN, RTM_NEWROUTE);
-out_rtnl_register2:
- rtnl_unregister(PF_CAN, RTM_GETROUTE);
-out_rtnl_register1:
+out_rtnl_register:
unregister_netdevice_notifier(¬ifier);
out_register_notifier:
kmem_cache_destroy(cgw_cache);
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2024-10-11 22:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 22:05 [PATCH v1 net-next 00/11] rtnetlink: Use rtnl_register_many() Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 01/11] rtnetlink: Panic when __rtnl_register_many() fails for builtin callers Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 02/11] rtnetlink: Use rtnl_register_many() Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 03/11] neighbour: " Kuniyuki Iwashima
2024-10-14 8:01 ` Eric Dumazet
2024-10-14 17:35 ` Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 04/11] net: sched: " Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 05/11] net: " Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 06/11] ipv4: " Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 07/11] ipv6: " Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 08/11] ipmr: " Kuniyuki Iwashima
2024-10-11 22:05 ` [PATCH v1 net-next 09/11] dcb: " Kuniyuki Iwashima
2024-10-11 22:05 ` Kuniyuki Iwashima [this message]
2024-10-11 22:05 ` [PATCH v1 net-next 11/11] rtnetlink: Remove rtnl_register() and rtnl_register_module() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011220550.46040-11-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).