From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F412A204F77; Sat, 12 Oct 2024 11:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728732600; cv=none; b=CVX8LIXWcay8yMWBVs0iZqUyyWYAt+U/k5zsQ/oA3h7NnJiaPLxPQJ7xXCQKIjhYWwyreGpANpU931CfuoUa3oPjVKKLsF6AjgY1GOsWYl/Bjn/FsAH/vAc/4KYbhWScxQ0flEHZqqn8ltfkiCcFXVmYqaPoJX9XASnxwMWO5JI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728732600; c=relaxed/simple; bh=PNoNd7ySCCKZSMeht91COu5h8hrIkKAZ4nWz2IT5jlo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ONvzPbaZy0fp/oXolO6EkyJ2Jp63rcEWytPCIFJs9xiyQyyk2T55fxrYXTu4jYTSp3tyD5sZW8g4c74gJXSIkADM8AWhGHPcdfXIiR+rGmGTcHycu4XgrfRI07VY5/COpX4XQsCdtGdMTMKr+7DjZwBiHaCYZF7rAXsG57P+Tc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M23v9F6s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M23v9F6s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D0C5C4CEC7; Sat, 12 Oct 2024 11:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728732599; bh=PNoNd7ySCCKZSMeht91COu5h8hrIkKAZ4nWz2IT5jlo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M23v9F6sADI7KumI0IvWYqs9R6vns8dvXojRKSBSWdUHFO4PL9ZhktTUGZlSC+fN8 ZfKiNgUXtkvej+aCZcujM0jl2Ujx7pSr94V9qzuT54k/oB/l+qCn/nmVskxPLMT2Wz K+woNKRrKgyLfdaa+O8LHTxsr4qY0Jxk7keSsjOtzXXz+t72zQavG5i4q8jQmsVkel y8hvYfUGBBmI7oiovBIQZGafef38RLbYQY1pViDpAVN6pkIbjROCYnG9yZHrVuiDtj RnSOUGgBAucccmXwGKNjFDAvucZg5dpMX2MoR+RM07Ml9DVVKAzZX80LnFNA3Nnis6 uAclSWgaSFM5A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pawel Dembicki , Linus Walleij , "David S . Miller" , Sasha Levin , andrew@lunn.ch, hkallweit1@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 4/7] net: phy: vitesse: repair vsc73xx autonegotiation Date: Sat, 12 Oct 2024 07:29:39 -0400 Message-ID: <20241012112948.1764454-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241012112948.1764454-1-sashal@kernel.org> References: <20241012112948.1764454-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.284 Content-Transfer-Encoding: 8bit From: Pawel Dembicki [ Upstream commit de7a670f8defe4ed2115552ad23dea0f432f7be4 ] When the vsc73xx mdio bus work properly, the generic autonegotiation configuration works well. Reviewed-by: Linus Walleij Signed-off-by: Pawel Dembicki Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/vitesse.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c index bb680352708a6..3f594c8784e20 100644 --- a/drivers/net/phy/vitesse.c +++ b/drivers/net/phy/vitesse.c @@ -232,16 +232,6 @@ static int vsc739x_config_init(struct phy_device *phydev) return 0; } -static int vsc73xx_config_aneg(struct phy_device *phydev) -{ - /* The VSC73xx switches does not like to be instructed to - * do autonegotiation in any way, it prefers that you just go - * with the power-on/reset defaults. Writing some registers will - * just make autonegotiation permanently fail. - */ - return 0; -} - /* This adds a skew for both TX and RX clocks, so the skew should only be * applied to "rgmii-id" interfaces. It may not work as expected * on "rgmii-txid", "rgmii-rxid" or "rgmii" interfaces. */ @@ -424,7 +414,6 @@ static struct phy_driver vsc82xx_driver[] = { .phy_id_mask = 0x000ffff0, /* PHY_GBIT_FEATURES */ .config_init = vsc738x_config_init, - .config_aneg = vsc73xx_config_aneg, .read_page = vsc73xx_read_page, .write_page = vsc73xx_write_page, }, { @@ -433,7 +422,6 @@ static struct phy_driver vsc82xx_driver[] = { .phy_id_mask = 0x000ffff0, /* PHY_GBIT_FEATURES */ .config_init = vsc738x_config_init, - .config_aneg = vsc73xx_config_aneg, .read_page = vsc73xx_read_page, .write_page = vsc73xx_write_page, }, { @@ -442,7 +430,6 @@ static struct phy_driver vsc82xx_driver[] = { .phy_id_mask = 0x000ffff0, /* PHY_GBIT_FEATURES */ .config_init = vsc739x_config_init, - .config_aneg = vsc73xx_config_aneg, .read_page = vsc73xx_read_page, .write_page = vsc73xx_write_page, }, { @@ -451,7 +438,6 @@ static struct phy_driver vsc82xx_driver[] = { .phy_id_mask = 0x000ffff0, /* PHY_GBIT_FEATURES */ .config_init = vsc739x_config_init, - .config_aneg = vsc73xx_config_aneg, .read_page = vsc73xx_read_page, .write_page = vsc73xx_write_page, }, { -- 2.43.0