netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2 net-next 0/3] add gettimex64() support for mlx4
@ 2024-10-12 11:47 Mahesh Bandewar
  2024-10-17  9:22 ` Paolo Abeni
  0 siblings, 1 reply; 4+ messages in thread
From: Mahesh Bandewar @ 2024-10-12 11:47 UTC (permalink / raw)
  To: Netdev, Tariq Toukan, Yishai Hadas
  Cc: Eric Dumazet, Jakub Kicinski, David Miller, Paolo Abeni,
	Richard Cochran, Mahesh Bandewar, Mahesh Bandewar

The current driver only supports the gettime64() PTP clock read
operation. This series introduces support for gettimex64(), which
provides pre- and post-timestamps using one of the supported clock
bases to help measure the clock-read width.

The first patch reorganizes the code to enable the existing
clock-read method to handle pre- and post-timestamps. The second
patch adds the gettimex64() functionality.

Mahesh Bandewar (3):
  mlx4: introduce the time_cache into the mlx4 PTP implementation
  mlx4: update mlx4_read_clock() to provide pre/post timestamps
  mlx4: add gettimex64() ptp method

 drivers/net/ethernet/mellanox/mlx4/en_clock.c | 50 +++++++++++++++++--
 drivers/net/ethernet/mellanox/mlx4/main.c     | 12 +++--
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h  |  1 +
 include/linux/mlx4/device.h                   |  3 +-
 4 files changed, 57 insertions(+), 9 deletions(-)

v1->v2
  * Split the original patch that implemented time-cache and added 
    pre-/post-timestamp into two separate patches.
-- 
2.47.0.rc1.288.g06298d1525-goog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2 net-next 0/3] add gettimex64() support for mlx4
  2024-10-12 11:47 [PATCHv2 net-next 0/3] add gettimex64() support for mlx4 Mahesh Bandewar
@ 2024-10-17  9:22 ` Paolo Abeni
  2024-10-17 14:03   ` Richard Cochran
  0 siblings, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2024-10-17  9:22 UTC (permalink / raw)
  To: Mahesh Bandewar, Netdev, Tariq Toukan, Yishai Hadas
  Cc: Eric Dumazet, Jakub Kicinski, David Miller, Richard Cochran,
	Mahesh Bandewar

On 10/12/24 13:47, Mahesh Bandewar wrote:
> The current driver only supports the gettime64() PTP clock read
> operation. This series introduces support for gettimex64(), which
> provides pre- and post-timestamps using one of the supported clock
> bases to help measure the clock-read width.
> 
> The first patch reorganizes the code to enable the existing
> clock-read method to handle pre- and post-timestamps. The second
> patch adds the gettimex64() functionality.

This paragraph is outdated, you must update the cover letter according 
to the series contents.

Additionally please fix you git configuration; you should set 
format.thread=shallow

Thanks,

Paolo


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2 net-next 0/3] add gettimex64() support for mlx4
  2024-10-17  9:22 ` Paolo Abeni
@ 2024-10-17 14:03   ` Richard Cochran
  2024-10-28 18:16     ` Mahesh Bandewar (महेश बंडेवार)
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Cochran @ 2024-10-17 14:03 UTC (permalink / raw)
  To: Paolo Abeni
  Cc: Mahesh Bandewar, Netdev, Tariq Toukan, Yishai Hadas, Eric Dumazet,
	Jakub Kicinski, David Miller, Mahesh Bandewar

On Thu, Oct 17, 2024 at 11:22:12AM +0200, Paolo Abeni wrote:
> Additionally please fix you git configuration; you should set
> format.thread=shallow

Yes, this ^^^ makes review much easier for us.

Thanks,
Richard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2 net-next 0/3] add gettimex64() support for mlx4
  2024-10-17 14:03   ` Richard Cochran
@ 2024-10-28 18:16     ` Mahesh Bandewar (महेश बंडेवार)
  0 siblings, 0 replies; 4+ messages in thread
From: Mahesh Bandewar (महेश बंडेवार) @ 2024-10-28 18:16 UTC (permalink / raw)
  To: Richard Cochran
  Cc: Paolo Abeni, Netdev, Tariq Toukan, Yishai Hadas, Eric Dumazet,
	Jakub Kicinski, David Miller, Mahesh Bandewar

On Thu, Oct 17, 2024 at 7:03 AM Richard Cochran
<richardcochran@gmail.com> wrote:
>
> On Thu, Oct 17, 2024 at 11:22:12AM +0200, Paolo Abeni wrote:
> > Additionally please fix you git configuration; you should set
> > format.thread=shallow
>
> Yes, this ^^^ makes review much easier for us.
>
I see. Thank you both for the suggestion.

> Thanks,
> Richard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-28 18:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-12 11:47 [PATCHv2 net-next 0/3] add gettimex64() support for mlx4 Mahesh Bandewar
2024-10-17  9:22 ` Paolo Abeni
2024-10-17 14:03   ` Richard Cochran
2024-10-28 18:16     ` Mahesh Bandewar (महेश बंडेवार)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).