Re: Build regressions/improvements in v6.12-rc3

Re: Build regressions/improvements in v6.12-rc3

[Geert Uytterhoeven]

On Mon, 14 Oct 2024, Geert Uytterhoeven wrote:
> JFYI, when comparing v6.12-rc3[1] to v6.12-rc2[3], the summaries are:
>  - build errors: +3/-1

   + /kisskb/src/crypto/async_tx/async_tx.c: error: no previous prototype for '__async_tx_find_channel' [-Werror=missing-prototypes]:  => 43:1

powerpc-gcc{5,13}/ppc44x_allmodconfig

   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]:  => 126:37
   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]:  => 126:46

powerpc-gcc{5,13}/ppc85xx_allmodconfig

> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8e929cb546ee42c9a61d24fae60605e9e3192354/ (all 194 configs)
> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b/ (131 out of 194 configs)

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds

Re: Build regressions/improvements in v6.12-rc3

[Simon Horman]

On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote:
> On Mon, 14 Oct 2024, Geert Uytterhoeven wrote:
> > JFYI, when comparing v6.12-rc3[1] to v6.12-rc2[3], the summaries are:
> >  - build errors: +3/-1
> 
>   + /kisskb/src/crypto/async_tx/async_tx.c: error: no previous prototype for '__async_tx_find_channel' [-Werror=missing-prototypes]:  => 43:1
> 
> powerpc-gcc{5,13}/ppc44x_allmodconfig
> 
>   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]:  => 126:37
>   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]:  => 126:46

Hi Geert, all,

I wonder what the correct string format is in these cases?
I didn't have a good idea the last time I looked.

> 
> powerpc-gcc{5,13}/ppc85xx_allmodconfig
> 
> > [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8e929cb546ee42c9a61d24fae60605e9e3192354/ (all 194 configs)
> > [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b/ (131 out of 194 configs)

...

Re: Build regressions/improvements in v6.12-rc3

[Geert Uytterhoeven]

Hi Simon,

On Mon, Oct 14, 2024 at 10:58 AM Simon Horman <horms@kernel.org> wrote:
> On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote:
> >   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]:  => 126:37
> >   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]:  => 126:46
>
> I wonder what the correct string format is in these cases?
> I didn't have a good idea the last time I looked.

"%pa" + taking the address of the resource_size_t object.

https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: Build regressions/improvements in v6.12-rc3

[Simon Horman]

On Mon, Oct 14, 2024 at 11:18:14AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Oct 14, 2024 at 10:58 AM Simon Horman <horms@kernel.org> wrote:
> > On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote:
> > >   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]:  => 126:37
> > >   + /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]:  => 126:46
> >
> > I wonder what the correct string format is in these cases?
> > I didn't have a good idea the last time I looked.
> 
> "%pa" + taking the address of the resource_size_t object.
> 
> https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229

Thanks,

These format problems seem to have been introduced quite some time ago
by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string").
I'll send some patches to address the ones introduced by that patch
that I was able to still find in-tree.