From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Daniel Zahka <daniel.zahka@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ethtool: rss: prevent rss ctx deletion when in use
Date: Mon, 14 Oct 2024 17:53:55 -0700 [thread overview]
Message-ID: <20241014175355.62d40b01@kernel.org> (raw)
In-Reply-To: <966a82d9-c835-e87e-2c54-90a9a2552a21@gmail.com>
On Mon, 14 Oct 2024 11:10:33 +0100 Edward Cree wrote:
> On 11/10/2024 19:35, Daniel Zahka wrote:
> > A list of active
> > ntuple filters and their associated rss contexts can be compiled by
> > querying a device's ethtool_ops.get_rxnfc. This patch checks to see if
> > any ntuple filters are referencing an rss context during context
> > deletion, and prevents the deletion if the requested context is still
> > in use.
>
> Imho it would make more sense to add core tracking of ntuple
> filters, along with a refcount on the rss context. That way
> context deletion just has to check the count is zero.
True... This is my least favorite kind of situation, where the posted
code is clearly much better than the status quo, but even better
solution is possible. So question becomes do we push for the optimal
solution and potentially get neither or do we apply what's posted and
hope the better one will still be delivered later..
next prev parent reply other threads:[~2024-10-15 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 18:35 [PATCH net-next 0/2] ethtool: rss: track rss ctx busy from core Daniel Zahka
2024-10-11 18:35 ` [PATCH net-next 1/2] ethtool: rss: prevent rss ctx deletion when in use Daniel Zahka
2024-10-14 10:10 ` Edward Cree
2024-10-15 0:53 ` Jakub Kicinski [this message]
2024-10-15 16:31 ` Daniel Zahka
2024-10-16 16:23 ` Edward Cree
2024-10-16 16:50 ` Daniel Zahka
2024-10-17 8:21 ` Paolo Abeni
2024-10-11 18:35 ` [PATCH net-next 2/2] selftests: drv-net: rss_ctx: add rss ctx busy testcase Daniel Zahka
2024-10-17 8:30 ` [PATCH net-next 0/2] ethtool: rss: track rss ctx busy from core patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014175355.62d40b01@kernel.org \
--to=kuba@kernel.org \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).