From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <ignat@cloudflare.com>
Cc: <alex.aring@gmail.com>, <alibuda@linux.alibaba.com>,
<davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <johan.hedberg@gmail.com>,
<kernel-team@cloudflare.com>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <linux-bluetooth@vger.kernel.org>,
<linux-can@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-wpan@vger.kernel.org>, <luiz.dentz@gmail.com>,
<marcel@holtmann.org>, <miquel.raynal@bootlin.com>,
<mkl@pengutronix.de>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <socketcan@hartkopp.net>,
<stefan@datenfreihafen.org>, <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next v3 9/9] Revert "net: do not leave a dangling sk pointer, when socket creation fails"
Date: Mon, 14 Oct 2024 14:42:36 -0700 [thread overview]
Message-ID: <20241014214236.99604-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241014153808.51894-10-ignat@cloudflare.com>
From: Ignat Korchagin <ignat@cloudflare.com>
Date: Mon, 14 Oct 2024 16:38:08 +0100
> This reverts commit 6cd4a78d962bebbaf8beb7d2ead3f34120e3f7b2.
>
> inet/inet6->create() implementations have been fixed to explicitly NULL the
> allocated sk object on error.
>
> A warning was put in place to make sure any future changes will not leave
> a dangling pointer in pf->create() implementations.
>
> So this code is now redundant.
>
> Suggested-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2024-10-14 21:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 15:37 [PATCH net-next v3 0/9] do not leave dangling sk pointers in pf->create functions Ignat Korchagin
2024-10-14 15:38 ` [PATCH net-next v3 1/9] af_packet: avoid erroring out after sock_init_data() in packet_create() Ignat Korchagin
2024-10-14 21:14 ` Kuniyuki Iwashima
2024-10-15 0:52 ` Willem de Bruijn
2024-10-15 8:01 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 2/9] Bluetooth: L2CAP: do not leave dangling sk pointer on error in l2cap_sock_create() Ignat Korchagin
2024-10-14 21:23 ` Kuniyuki Iwashima
2024-10-15 8:03 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 3/9] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc() Ignat Korchagin
2024-10-14 21:29 ` Kuniyuki Iwashima
2024-10-15 8:04 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 4/9] net: af_can: do not leave a dangling sk pointer in can_create() Ignat Korchagin
2024-10-14 21:32 ` Kuniyuki Iwashima
2024-10-15 6:21 ` Marc Kleine-Budde
2024-10-14 15:38 ` [PATCH net-next v3 5/9] net: ieee802154: do not leave a dangling sk pointer in ieee802154_create() Ignat Korchagin
2024-10-14 21:35 ` Kuniyuki Iwashima
2024-10-15 8:05 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 6/9] net: inet: do not leave a dangling sk pointer in inet_create() Ignat Korchagin
2024-10-14 21:37 ` Kuniyuki Iwashima
2024-10-15 8:05 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 7/9] net: inet6: do not leave a dangling sk pointer in inet6_create() Ignat Korchagin
2024-10-14 21:38 ` Kuniyuki Iwashima
2024-10-15 8:11 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 8/9] net: warn, if pf->create does not clear sock->sk on error Ignat Korchagin
2024-10-14 21:40 ` Kuniyuki Iwashima
2024-10-15 8:06 ` Eric Dumazet
2024-10-14 15:38 ` [PATCH net-next v3 9/9] Revert "net: do not leave a dangling sk pointer, when socket creation fails" Ignat Korchagin
2024-10-14 21:42 ` Kuniyuki Iwashima [this message]
2024-10-15 8:06 ` Eric Dumazet
2024-10-16 1:50 ` [PATCH net-next v3 0/9] do not leave dangling sk pointers in pf->create functions patchwork-bot+netdevbpf
2024-10-16 19:05 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014214236.99604-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=alex.aring@gmail.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ignat@cloudflare.com \
--cc=johan.hedberg@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=miquel.raynal@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=socketcan@hartkopp.net \
--cc=stefan@datenfreihafen.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).