* [PATCH 2/3] selftests/net: Fix ./ns-XXXXXX not cleanup
[not found] <20241015010817.453539-1-lizhijian@fujitsu.com>
@ 2024-10-15 1:08 ` Li Zhijian
2024-10-15 15:43 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Li Zhijian @ 2024-10-15 1:08 UTC (permalink / raw)
To: linux-kselftest, Shuah Khan
Cc: linux-kernel, Li Zhijian, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
```
readonly STATS="$(mktemp -p /tmp ns-XXXXXX)"
readonly BASE=`basename $STATS`
```
It would be a mistake to write to $BASE rather than $STATS, where $STATS
is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
Cc: netdev@vger.kernel.org
---
tools/testing/selftests/net/veth.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
index 4f1edbafb946..457312ef135a 100755
--- a/tools/testing/selftests/net/veth.sh
+++ b/tools/testing/selftests/net/veth.sh
@@ -46,8 +46,8 @@ create_ns() {
ip -n $BASE$ns addr add dev veth$ns $BM_NET_V4$ns/24
ip -n $BASE$ns addr add dev veth$ns $BM_NET_V6$ns/64 nodad
done
- echo "#kernel" > $BASE
- chmod go-rw $BASE
+ echo "#kernel" > $STATS
+ chmod go-rw $STATS
}
__chk_flag() {
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread