netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Pantelis Antoniou <pantelis.antoniou@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] net: ethernet: freescale: Use %pa to format resource_size_t
Date: Tue, 15 Oct 2024 13:10:47 +0100	[thread overview]
Message-ID: <20241015121047.GE569285@kernel.org> (raw)
In-Reply-To: <20241015072448.6ssv6vsyjpv4vnhi@DEN-DL-M70577>

On Tue, Oct 15, 2024 at 07:24:48AM +0000, Daniel Machon wrote:
> > Hi,
> > 
> > This short series addersses the formatting of variables of
> > type resource_size_t in freescale drivers.
> > 
> > The correct format string for resource_size_t is %pa which
> > acts on the address of the variable to be formatted [1].
> > 
> > [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229
> > 
> > These problems were introduced by
> > commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string")
> > 
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cce99@linux-m68k.org/
> > 
> > ---
> > Simon Horman (2):
> >       net: fec_mpc52xx_phy: Use %pa to format resource_size_t
> >       net: ethernet: fs_enet: Use %pa to format resource_size_t
> > 
> >  drivers/net/ethernet/freescale/fec_mpc52xx_phy.c     | 2 +-
> >  drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > base-commit: 6aac56631831e1386b6edd3c583c8afb2abfd267
> > 
> 
> Hi Simon,
> 
> Is this for net-next? I dont see a target tree name :-)

Hi Daniel,

Yes, it is. Sorry for forgetting to include that in the subject.

> Looking at the docs, %pa seems correct to me.
> 
> For the series:
> 
> Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
> 

  reply	other threads:[~2024-10-15 12:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 10:48 [PATCH 0/2] net: ethernet: freescale: Use %pa to format resource_size_t Simon Horman
2024-10-14 10:48 ` [PATCH 1/2] net: fec_mpc52xx_phy: " Simon Horman
2024-10-14 10:48 ` [PATCH 2/2] net: ethernet: fs_enet: " Simon Horman
2024-10-15  7:24 ` [PATCH 0/2] net: ethernet: freescale: " Daniel Machon
2024-10-15 12:10   ` Simon Horman [this message]
2024-10-15 18:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015121047.GE569285@kernel.org \
    --to=horms@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pantelis.antoniou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).