From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Wang Hai <wanghai38@huawei.com>,
bcm-kernel-feedback-list@broadcom.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, zhangxiaoxu5@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: systemport: fix potential memory leak in bcm_sysport_xmit()
Date: Tue, 15 Oct 2024 12:54:34 -0700 [thread overview]
Message-ID: <20241015125434.7e9dfb04@kernel.org> (raw)
In-Reply-To: <ed541d60-46dd-4b23-b810-548166b7a826@broadcom.com>
On Tue, 15 Oct 2024 11:07:29 -0700 Florian Fainelli wrote:
> >> Since we already have a private counter tracking DMA mapping errors, I
> >> would follow what the driver does elsewhere in the transmit path,
> >> especially what bcm_sysport_insert_tsb() does, and just use
> >> dev_consume_skb_any() here.
> >
> > Are you saying that if the packet drop is accounted is some statistics
> > we should not inform drop monitor about it? 🤔️
> > That wasn't my understanding of kfree_skb vs consume_skb..
>
> Yes that's my reasoning here, now given that we have had packet drops on
> transmit that took forever to track down, maybe I better retract that
> statement and go with v1.
Sounds good, we can apply v1. Would you like to ack/review here?
next prev parent reply other threads:[~2024-10-15 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 14:51 [PATCH net] net: systemport: fix potential memory leak in bcm_sysport_xmit() Wang Hai
2024-10-14 16:59 ` Florian Fainelli
2024-10-15 14:54 ` Wang Hai
2024-10-15 18:01 ` Jakub Kicinski
2024-10-15 18:07 ` Florian Fainelli
2024-10-15 19:54 ` Jakub Kicinski [this message]
2024-10-15 23:55 ` Florian Fainelli
2024-10-16 0:00 ` Jakub Kicinski
2024-10-15 23:53 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015125434.7e9dfb04@kernel.org \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wanghai38@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).