From: Paul Barker <paul.barker.ct@bp.renesas.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Paul Barker" <paul.barker.ct@bp.renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [net-next PATCH v2 00/10] Extend GbEth checksum offload support to VLAN/IPv6 packets
Date: Tue, 15 Oct 2024 14:36:24 +0100 [thread overview]
Message-ID: <20241015133634.193-1-paul.barker.ct@bp.renesas.com> (raw)
The GbEth IP found in Renesas RZ/G2L, RZ/G3S and related SoCs supports
hardware checksum offload for packets in the following cases:
- there are zero or one VLAN headers with TPID=0x8100
- the network protocol is IPv4 or IPv6
- the transport protocol is TCP, UDP or ICMP
- the packet is not fragmented
To complete the support for all these cases in the ravb driver, we need
to add handling for VLAN-tagged packets and IPv6 packets in both the TX
and RX code paths. Handling for ICMP packets in the TX path is not added
as it cannot currently be tested.
These patches also do some refactoring/tidy-up, drop unnecessary checks
from performance sensitive code paths and disable unnecessary IP header
checksum offloading.
Changes v1->v2:
- Use get_unaligned() to access hw_csum in ravb_rx_csum_gbeth().
- Dropped patch "Support ICMP TX checksum offload for GbEth" and
simplified TX checksum offload path.
- Moved last_frag into if condition in ravb_can_tx_csum_gbeth().
- Dropped unnecessary check for skb->vlan_proto in
ravb_can_tx_csum_gbeth().
- s/HW/hardware/ in "Simplify types in RX csum validation" commit
message.
- s/null/zero/ in "Simplify UDP TX checksum offload" commit message.
- Specified TX/RX direction in "Enable IPv6 TX/RX checksum offloading
for GbEth" commit messages.
- Dropped unnecessary whitespace.
- Added Sergey's Reviewed-by tags.
Paul Barker (10):
net: ravb: Factor out checksum offload enable bits
net: ravb: Disable IP header RX checksum offloading
net: ravb: Drop IP protocol check from RX csum verification
net: ravb: Combine if conditions in RX csum validation
net: ravb: Simplify types in RX csum validation
net: ravb: Disable IP header TX checksum offloading
net: ravb: Simplify UDP TX checksum offload
net: ravb: Enable IPv6 RX checksum offloading for GbEth
net: ravb: Enable IPv6 TX checksum offload for GbEth
net: ravb: Add VLAN checksum support
drivers/net/ethernet/renesas/ravb.h | 6 ++
drivers/net/ethernet/renesas/ravb_main.c | 101 ++++++++++++-----------
2 files changed, 61 insertions(+), 46 deletions(-)
--
2.43.0
next reply other threads:[~2024-10-15 13:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 13:36 Paul Barker [this message]
2024-10-15 13:36 ` [net-next PATCH v2 01/10] net: ravb: Factor out checksum offload enable bits Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 02/10] net: ravb: Disable IP header RX checksum offloading Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 03/10] net: ravb: Drop IP protocol check from RX csum verification Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 04/10] net: ravb: Combine if conditions in RX csum validation Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 05/10] net: ravb: Simplify types " Paul Barker
2024-10-15 15:23 ` Sergey Shtylyov
2024-10-15 13:36 ` [net-next PATCH v2 06/10] net: ravb: Disable IP header TX checksum offloading Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 07/10] net: ravb: Simplify UDP TX checksum offload Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 08/10] net: ravb: Enable IPv6 RX checksum offloading for GbEth Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 09/10] net: ravb: Enable IPv6 TX checksum offload " Paul Barker
2024-10-15 15:47 ` Sergey Shtylyov
2024-10-15 13:36 ` [net-next PATCH v2 10/10] net: ravb: Add VLAN checksum support Paul Barker
2024-10-15 15:50 ` Sergey Shtylyov
2024-10-18 2:30 ` [net-next PATCH v2 00/10] Extend GbEth checksum offload support to VLAN/IPv6 packets patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015133634.193-1-paul.barker.ct@bp.renesas.com \
--to=paul.barker.ct@bp.renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).