From: Paul Barker <paul.barker.ct@bp.renesas.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Paul Barker" <paul.barker.ct@bp.renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [net-next PATCH v2 06/10] net: ravb: Disable IP header TX checksum offloading
Date: Tue, 15 Oct 2024 14:36:30 +0100 [thread overview]
Message-ID: <20241015133634.193-7-paul.barker.ct@bp.renesas.com> (raw)
In-Reply-To: <20241015133634.193-1-paul.barker.ct@bp.renesas.com>
For IPv4 packets, the header checksum will always be calculated in software
in the TX path (Documentation/networking/checksum-offloads.rst says "No
offloading of the IP header checksum is performed; it is always done in
software.") so there is no advantage in asking the hardware to also
calculate this checksum.
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
---
drivers/net/ethernet/renesas/ravb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index 98496aa39f3d..a5b4f4fe77b1 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -998,7 +998,7 @@ enum CSR1_BIT {
CSR1_TDHD = 0x08000000,
};
-#define CSR1_CSUM_ENABLE (CSR1_TIP4 | CSR1_TTCP4 | CSR1_TUDP4)
+#define CSR1_CSUM_ENABLE (CSR1_TTCP4 | CSR1_TUDP4)
enum CSR2_BIT {
CSR2_RIP4 = 0x00000001,
--
2.43.0
next prev parent reply other threads:[~2024-10-15 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 13:36 [net-next PATCH v2 00/10] Extend GbEth checksum offload support to VLAN/IPv6 packets Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 01/10] net: ravb: Factor out checksum offload enable bits Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 02/10] net: ravb: Disable IP header RX checksum offloading Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 03/10] net: ravb: Drop IP protocol check from RX csum verification Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 04/10] net: ravb: Combine if conditions in RX csum validation Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 05/10] net: ravb: Simplify types " Paul Barker
2024-10-15 15:23 ` Sergey Shtylyov
2024-10-15 13:36 ` Paul Barker [this message]
2024-10-15 13:36 ` [net-next PATCH v2 07/10] net: ravb: Simplify UDP TX checksum offload Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 08/10] net: ravb: Enable IPv6 RX checksum offloading for GbEth Paul Barker
2024-10-15 13:36 ` [net-next PATCH v2 09/10] net: ravb: Enable IPv6 TX checksum offload " Paul Barker
2024-10-15 15:47 ` Sergey Shtylyov
2024-10-15 13:36 ` [net-next PATCH v2 10/10] net: ravb: Add VLAN checksum support Paul Barker
2024-10-15 15:50 ` Sergey Shtylyov
2024-10-18 2:30 ` [net-next PATCH v2 00/10] Extend GbEth checksum offload support to VLAN/IPv6 packets patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015133634.193-7-paul.barker.ct@bp.renesas.com \
--to=paul.barker.ct@bp.renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).