From: Jakub Kicinski <kuba@kernel.org>
To: Ales Nezbeda <anezbeda@redhat.com>
Cc: netdev@vger.kernel.org, sd@queasysnail.net
Subject: Re: [PATCH net] netdevsim: macsec: pad u64 to correct length in logs
Date: Tue, 15 Oct 2024 16:35:21 -0700 [thread overview]
Message-ID: <20241015163521.3765bd68@kernel.org> (raw)
In-Reply-To: <20241015110943.94217-1-anezbeda@redhat.com>
On Tue, 15 Oct 2024 13:09:43 +0200 Ales Nezbeda wrote:
> Currently, we pad u64 number to 8 characters using "%08llx" format
> specifier.
>
> Changing format specifier to "%016llx" ensures that no matter the value
> the representation of number in log is always the same length.
>
> Before this patch, entry in log for value '1' would say:
> removing SecY with SCI 00000001 at index 2
> After this patch is applied, entry in log will say:
> removing SecY with SCI 0000000000000001 at index 2
>
> Fixes: 02b34d03a24b ("netdevsim: add dummy macsec offload")
padding prints in a test harness is not a fix so let's drop the Fixes
tag and repost against net-next
--
pw-bot: cr
prev parent reply other threads:[~2024-10-15 23:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 11:09 [PATCH net] netdevsim: macsec: pad u64 to correct length in logs Ales Nezbeda
2024-10-15 23:35 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015163521.3765bd68@kernel.org \
--to=kuba@kernel.org \
--cc=anezbeda@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).