From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<shenjian15@huawei.com>, <salil.mehta@huawei.com>,
<liuyonglong@huawei.com>, <wangpeiyang1@huawei.com>,
<lanhao@huawei.com>, <chenhao418@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 1/9] net: hns3: default enable tx bounce buffer when smmu enabled
Date: Tue, 15 Oct 2024 18:16:57 -0700 [thread overview]
Message-ID: <20241015181657.14fe9227@kernel.org> (raw)
In-Reply-To: <20241011094521.3008298-2-shaojijie@huawei.com>
On Fri, 11 Oct 2024 17:45:13 +0800 Jijie Shao wrote:
> From: Peiyang Wang <wangpeiyang1@huawei.com>
>
> When TX bounce buffer is enabled, dma map is used only when the buffer
> initialized. When spending packages, the driver only do dma sync. To
packages -> packets
> avoid SMMU prefetch, default enable tx bounce buffer if smmu enabled.
you seem to force it to be enabled, rather than just changing
the default. That is strange. Why not let the user lower the value?
Also I don't see why this is a fix. Seems like a performance
improvement.
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-16 1:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 9:45 [PATCH net 0/9] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-10-11 9:45 ` [PATCH net 1/9] net: hns3: default enable tx bounce buffer when smmu enabled Jijie Shao
2024-10-16 1:16 ` Jakub Kicinski [this message]
2024-10-16 11:37 ` Jijie Shao
2024-10-16 11:44 ` Jijie Shao
2024-10-11 9:45 ` [PATCH net 2/9] net: hns3: add sync command to sync io-pgtable Jijie Shao
2024-10-16 1:19 ` Jakub Kicinski
2024-10-16 11:53 ` Jijie Shao
2024-10-11 9:45 ` [PATCH net 3/9] net: hns3: fixed reset failure issues caused by the incorrect reset type Jijie Shao
2024-10-11 9:45 ` [PATCH net 4/9] net: hns3: fix missing features due to dev->features configuration too early Jijie Shao
2024-10-11 9:45 ` [PATCH net 5/9] net: hns3: Resolved the issue that the debugfs query result is inconsistent Jijie Shao
2024-10-11 9:45 ` [PATCH net 6/9] net: hns3: don't auto enable misc vector Jijie Shao
2024-10-16 1:22 ` Jakub Kicinski
2024-10-16 11:57 ` Jijie Shao
2024-10-11 9:45 ` [PATCH net 7/9] net: hns3: initialize reset_timer before hclgevf_misc_irq_init() Jijie Shao
2024-10-11 9:45 ` [PATCH net 8/9] net: hns3: fixed hclge_fetch_pf_reg accesses bar space out of bounds issue Jijie Shao
2024-10-11 9:45 ` [PATCH net 9/9] net: hns3: fix kernel crash when 1588 is sent on HIP08 devices Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015181657.14fe9227@kernel.org \
--to=kuba@kernel.org \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lanhao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).