* [PATCH] net: plip: fix break; causing plip to never transmit
@ 2024-10-15 15:16 Jakub Boehm via B4 Relay
2024-10-16 14:17 ` Simon Horman
2024-10-20 14:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Boehm via B4 Relay @ 2024-10-15 15:16 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Gustavo A. R. Silva
Cc: netdev, linux-kernel, llvm, Jakub Boehm
From: Jakub Boehm <boehm.jakub@gmail.com>
Since commit
71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
plip was not able to send any packets, this patch replaces one
unintended break; with fallthrough; which was originally missed by
commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").
I have verified with a real hardware PLIP connection that everything
works once again after applying this patch.
Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com>
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
index e39bfaefe8c50ba72238d04f08deaa46ca650c70..d81163bc910a3bcaa770a10c0e2d7d9b334a381b 100644
--- a/drivers/net/plip/plip.c
+++ b/drivers/net/plip/plip.c
@@ -815,7 +815,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
return HS_TIMEOUT;
}
}
- break;
+ fallthrough;
case PLIP_PK_LENGTH_LSB:
if (plip_send(nibble_timeout, dev,
---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241015-net-plip-tx-fix-822e94e58a6e
Best regards,
--
Jakub Boehm <boehm.jakub@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: plip: fix break; causing plip to never transmit
2024-10-15 15:16 [PATCH] net: plip: fix break; causing plip to never transmit Jakub Boehm via B4 Relay
@ 2024-10-16 14:17 ` Simon Horman
2024-10-20 14:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-10-16 14:17 UTC (permalink / raw)
To: boehm.jakub
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Gustavo A. R. Silva, netdev, linux-kernel, llvm
On Tue, Oct 15, 2024 at 05:16:04PM +0200, Jakub Boehm via B4 Relay wrote:
> From: Jakub Boehm <boehm.jakub@gmail.com>
>
> Since commit
> 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
>
> plip was not able to send any packets, this patch replaces one
> unintended break; with fallthrough; which was originally missed by
> commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").
>
> I have verified with a real hardware PLIP connection that everything
> works once again after applying this patch.
>
> Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
> Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: plip: fix break; causing plip to never transmit
2024-10-15 15:16 [PATCH] net: plip: fix break; causing plip to never transmit Jakub Boehm via B4 Relay
2024-10-16 14:17 ` Simon Horman
@ 2024-10-20 14:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-20 14:50 UTC (permalink / raw)
To: Jakub Boehm via B4 Relay
Cc: davem, edumazet, kuba, pabeni, nathan, ndesaulniers, morbo,
justinstitt, gustavoars, netdev, linux-kernel, llvm, boehm.jakub
Hello:
This patch was applied to netdev/net.git (main)
by Andrew Lunn <andrew@lunn.ch>:
On Tue, 15 Oct 2024 17:16:04 +0200 you wrote:
> From: Jakub Boehm <boehm.jakub@gmail.com>
>
> Since commit
> 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
>
> plip was not able to send any packets, this patch replaces one
> unintended break; with fallthrough; which was originally missed by
> commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").
>
> [...]
Here is the summary with links:
- net: plip: fix break; causing plip to never transmit
https://git.kernel.org/netdev/net/c/f99cf996ba5a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-20 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 15:16 [PATCH] net: plip: fix break; causing plip to never transmit Jakub Boehm via B4 Relay
2024-10-16 14:17 ` Simon Horman
2024-10-20 14:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).