Re: [PATCH net-next v2 0/5] Removing more phylink cruft

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi,

On Wed, 16 Oct 2024 10:57:29 +0100
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:

> Hi,
> 
> Continuing on with the cleanups, this patch series removes
> dsa_port_phylink_mac_select_pcs() which is no longer required. This
> will have no functional effect as phylink does this:
> 
>         bool using_mac_select_pcs = false;
> 
>         if (mac_ops->mac_select_pcs &&
>             mac_ops->mac_select_pcs(config, PHY_INTERFACE_MODE_NA) !=
>               ERR_PTR(-EOPNOTSUPP))
>                 using_mac_select_pcs = true;
> 
> and no mac_select_pcs() method is equivalent to a mac_select_pcs()
> that returns -EOPNOTSUPP.
> 
> We then make mv88e6xxx_mac_select_pcs() return NULL, as we don't want
> to invoke this old behaviour anymore - mv88e6xxx doesn't require it.
> 
> Then, allow phylink to remove PCS, which has been a long standing
> behavioural oddity.
> 
> Remove the use of pl->pcs when validating as this will never be
> non-NULL unless "using_mac_select_pcs" was set.
> 
> This then clears the way to removing using_mac_select_pcs from phylink
> and the check.

I don't have any setup with such a switch or that could trigger the
PCS removal, so I couldn't fully test it. However it does look good to
me :)

For the series,

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime