From: Vladimir Oltean <olteanv@gmail.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v2 4/5] net: phylink: remove use of pl->pcs in phylink_validate_mac_and_pcs()
Date: Thu, 17 Oct 2024 10:01:21 +0300 [thread overview]
Message-ID: <20241017070121.soahbrrhgp7bpdjk@skbuf> (raw)
In-Reply-To: <E1t10nf-000AWi-PR@rmk-PC.armlinux.org.uk> <E1t10nf-000AWi-PR@rmk-PC.armlinux.org.uk>
On Wed, Oct 16, 2024 at 10:58:39AM +0100, Russell King (Oracle) wrote:
> When the mac_select_pcs() method is not implemented, there is no way
> for pl->pcs to be set to a non-NULL value. This was here to support
> the old phylink_set_pcs() method which has been removed a few years
> ago. Simplify the code in phylink_validate_mac_and_pcs().
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2024-10-17 7:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 9:57 [PATCH net-next v2 0/5] Removing more phylink cruft Russell King (Oracle)
2024-10-16 9:58 ` [PATCH net-next v2 1/5] net: dsa: remove dsa_port_phylink_mac_select_pcs() Russell King (Oracle)
2024-10-16 9:58 ` [PATCH net-next v2 2/5] net: dsa: mv88e6xxx: return NULL when no PCS is present Russell King (Oracle)
2024-10-16 9:58 ` [PATCH net-next v2 3/5] net: phylink: allow mac_select_pcs() to remove a PCS Russell King (Oracle)
2024-10-17 7:00 ` Vladimir Oltean
2024-10-16 9:58 ` [PATCH net-next v2 4/5] net: phylink: remove use of pl->pcs in phylink_validate_mac_and_pcs() Russell King (Oracle)
2024-10-17 7:01 ` Vladimir Oltean [this message]
2024-10-16 9:58 ` [PATCH net-next v2 5/5] net: phylink: remove "using_mac_select_pcs" Russell King (Oracle)
2024-10-17 7:06 ` Vladimir Oltean
2024-10-16 14:42 ` [PATCH net-next v2 0/5] Removing more phylink cruft Maxime Chevallier
2024-10-18 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017070121.soahbrrhgp7bpdjk@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).