From: Florian Westphal <fw@strlen.de>
To: "Maciej Żenczykowski" <maze@google.com>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, Nathan Harold <nharold@google.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Yan Yan <evitayan@google.com>
Subject: Re: [PATCH ipsec] xfrm: migrate: work around 0 if_id on migrate
Date: Thu, 17 Oct 2024 13:33:30 +0200 [thread overview]
Message-ID: <20241017113330.GB12005@breakpoint.cc> (raw)
In-Reply-To: <CANP3RGcWhTKOgNsCEb8bMNhktgdzXH+00s5zTKU3=iVocT5rqw@mail.gmail.com>
Maciej Żenczykowski <maze@google.com> wrote:
> > If you think a Kconfig knob makes sense for Android sake I can respin
> > with such a knob, but I think I'd have to make it default-y.
>
> I'll trust your judgment. I thought we could maybe eventually
> deprecate and delete this, but it sounds like that isn't going to be
> the case...
We could also say 'android fixed it in userspace' and not fix it
in kernel for now until someone else complains.
Or modify the pr_warn to also say something like
"deprecated and scheduled to be removed in 2026"?
I'm not thrilled with this patch :-)
next prev parent reply other threads:[~2024-10-17 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 9:43 [PATCH ipsec] xfrm: migrate: work around 0 if_id on migrate Florian Westphal
2024-10-17 10:39 ` Maciej Żenczykowski
2024-10-17 10:52 ` Florian Westphal
2024-10-17 11:03 ` Maciej Żenczykowski
2024-10-17 11:33 ` Florian Westphal [this message]
2024-10-17 13:21 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017113330.GB12005@breakpoint.cc \
--to=fw@strlen.de \
--cc=evitayan@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nharold@google.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).