From: Simon Horman <horms@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: avoid duplicated messages if loading firmware fails and switch to warn level
Date: Thu, 17 Oct 2024 16:54:04 +0100 [thread overview]
Message-ID: <20241017155404.GW1697@kernel.org> (raw)
In-Reply-To: <d9c5094c-89a6-40e2-b5fe-8df7df4624ef@gmail.com>
On Wed, Oct 16, 2024 at 10:29:39PM +0200, Heiner Kallweit wrote:
> In case of a problem with firmware loading we inform at the driver level,
> in addition the firmware load code itself issues warnings. Therefore
> switch to firmware_request_nowarn() to avoid duplicated error messages.
> In addition switch to warn level because the firmware is optional and
> typically just fixes compatibility issues.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thanks,
I agree that this is an appropriate use of firmware_request_nowarn()
which allows for uniform logging of error conditions by
rtl_fw_request_firmware().
I also agree that warnings are sufficient.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-17 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 20:29 [PATCH net-next] r8169: avoid duplicated messages if loading firmware fails and switch to warn level Heiner Kallweit
2024-10-17 15:54 ` Simon Horman [this message]
2024-10-20 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017155404.GW1697@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).