From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Remi Denis-Courmont <courmisch@gmail.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v1 net-next 0/9] phonet: Convert all doit() and dumpit() to RCU.
Date: Thu, 17 Oct 2024 11:31:31 -0700 [thread overview]
Message-ID: <20241017183140.43028-1-kuniyu@amazon.com> (raw)
addr_doit() and route_doit() access only phonet_device_list(dev_net(dev))
and phonet_pernet(dev_net(dev))->routes, respectively.
Each per-netns struct has its dedicated mutex, and RTNL also protects
the structs. __dev_change_net_namespace() has synchronize_net(), so
we have two options to convert addr_doit() and route_doit().
1. Use per-netns RTNL
2. Use RCU and convert each struct mutex to spinlock_t
As RCU is preferable, this series converts all PF_PHONET's doit()
and dumpit() to RCU.
4 doit()s and 1 dumpit() are now converted to RCU, 70 doit()s and
28 dumpit()s are still under RTNL.
Kuniyuki Iwashima (9):
phonet: Pass ifindex to fill_addr().
phonet: Pass net and ifindex to phonet_address_notify().
phonet: Convert phonet_device_list.lock to spinlock_t.
phonet: Don't hold RTNL for addr_doit().
phonet: Don't hold RTNL for getaddr_dumpit().
phonet: Pass ifindex to fill_route().
phonet: Pass net and ifindex to rtm_phonet_notify().
phonet: Convert phonet_routes.lock to spinlock_t.
phonet: Don't hold RTNL for route_doit().
include/net/phonet/pn_dev.h | 8 +--
net/phonet/pn_dev.c | 69 ++++++++++++++--------
net/phonet/pn_netlink.c | 115 ++++++++++++++++++++++--------------
3 files changed, 120 insertions(+), 72 deletions(-)
--
2.39.5 (Apple Git-154)
next reply other threads:[~2024-10-17 18:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 18:31 Kuniyuki Iwashima [this message]
2024-10-17 18:31 ` [PATCH v1 net-next 1/9] phonet: Pass ifindex to fill_addr() Kuniyuki Iwashima
2024-10-23 15:24 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 2/9] phonet: Pass net and ifindex to phonet_address_notify() Kuniyuki Iwashima
2024-10-23 15:25 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 3/9] phonet: Convert phonet_device_list.lock to spinlock_t Kuniyuki Iwashima
2024-10-23 15:26 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 4/9] phonet: Don't hold RTNL for addr_doit() Kuniyuki Iwashima
2024-10-23 15:27 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 5/9] phonet: Don't hold RTNL for getaddr_dumpit() Kuniyuki Iwashima
2024-10-17 18:49 ` Rémi Denis-Courmont
2024-10-18 17:16 ` Kuniyuki Iwashima
2024-10-19 7:48 ` Rémi Denis-Courmont
2024-10-20 1:30 ` Kuniyuki Iwashima
2024-10-23 11:04 ` Paolo Abeni
2024-10-23 11:16 ` Paolo Abeni
2024-10-23 15:30 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 6/9] phonet: Pass ifindex to fill_route() Kuniyuki Iwashima
2024-10-23 15:30 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 7/9] phonet: Pass net and ifindex to rtm_phonet_notify() Kuniyuki Iwashima
2024-10-23 15:32 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 8/9] phonet: Convert phonet_routes.lock to spinlock_t Kuniyuki Iwashima
2024-10-23 15:33 ` Eric Dumazet
2024-10-17 18:31 ` [PATCH v1 net-next 9/9] phonet: Don't hold RTNL for route_doit() Kuniyuki Iwashima
2024-10-23 15:34 ` Eric Dumazet
2024-10-24 14:10 ` [PATCH v1 net-next 0/9] phonet: Convert all doit() and dumpit() to RCU patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017183140.43028-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).