From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: [PATCH v1 3/7] devlink: devl_resource_register(): differentiate error codes
Date: Fri, 18 Oct 2024 12:18:32 +0200 [thread overview]
Message-ID: <20241018102009.10124-4-przemyslaw.kitszel@intel.com> (raw)
In-Reply-To: <20241018102009.10124-1-przemyslaw.kitszel@intel.com>
Differentiate error codes of devl_resource_register().
Replace one of -EINVAL exit paths by -EEXIST. This should aid developers
introducing new resources and registering them in the wrong order.
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
---
net/devlink/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/devlink/resource.c b/net/devlink/resource.c
index 5ce05e94f484..96c0ff24b65a 100644
--- a/net/devlink/resource.c
+++ b/net/devlink/resource.c
@@ -345,7 +345,7 @@ int devl_resource_register(struct devlink *devlink,
resource = devlink_resource_find(devlink, NULL, resource_id);
if (resource)
- return -EINVAL;
+ return -EEXIST;
resource = kzalloc(sizeof(*resource), GFP_KERNEL);
if (!resource)
--
2.46.0
next prev parent reply other threads:[~2024-10-18 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 10:18 [PATCH v1 0/7] devlink: minor cleanup Przemek Kitszel
2024-10-18 10:18 ` [PATCH v1 1/7] devlink: introduce devlink_nl_put_u64() Przemek Kitszel
2024-10-18 10:18 ` [PATCH v1 2/7] devlink: use devlink_nl_put_u64() helper Przemek Kitszel
2024-10-18 10:18 ` Przemek Kitszel [this message]
2024-10-18 10:18 ` [PATCH v1 4/7] devlink: region: snapshot IDs: consolidate error values Przemek Kitszel
2024-10-18 10:18 ` [PATCH v1 5/7] net: dsa: replace devlink resource registration calls by devl_ variants Przemek Kitszel
2024-10-18 10:18 ` [PATCH v1 6/7] devlink: remove unused devlink_resource_occ_get_register() and _unregister() Przemek Kitszel
2024-10-18 10:18 ` [PATCH v1 7/7] devlink: remove unused devlink_resource_register() Przemek Kitszel
2024-10-18 11:58 ` [PATCH v1 0/7] devlink: minor cleanup Jiri Pirko
2024-10-21 19:51 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018102009.10124-4-przemyslaw.kitszel@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox