From: Simon Horman <horms@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Pedro Tammela <pctammela@mojatatu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/sched: act_api: unexport tcf_action_dump_1()
Date: Fri, 18 Oct 2024 15:23:21 +0100 [thread overview]
Message-ID: <20241018142321.GQ1697@kernel.org> (raw)
In-Reply-To: <20241017161934.3599046-1-vladimir.oltean@nxp.com>
On Thu, Oct 17, 2024 at 07:19:34PM +0300, Vladimir Oltean wrote:
> This isn't used outside act_api.c, but is called by tcf_dump_walker()
> prior to its definition. So move it upwards and make it static.
>
> Simultaneously, reorder the variable declarations so that they follow
> the networking "reverse Christmas tree" coding style.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Christmas has come early this year :)
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-18 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 16:19 [PATCH net-next] net/sched: act_api: unexport tcf_action_dump_1() Vladimir Oltean
2024-10-18 14:23 ` Simon Horman [this message]
2024-10-18 17:03 ` Toke Høiland-Jørgensen
2024-10-23 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018142321.GQ1697@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).