From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF0D7204F67 for ; Fri, 18 Oct 2024 19:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729278855; cv=none; b=iYilnC5hef1ty2D1xXhD3HGdPMz0qxWZiDfXBpO1JY8rlZucVQfUTW+uy0EDOkQQEilKkDZWc65s3nO6An4ofMuk20Bh5qQvFB+PiwgBMHNFF0ukWmEO26ZSXwtPe9LqS7oj3ckBFjJzxGErIH5iIIliY0Ezg+0fUh9MM/Go0c8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729278855; c=relaxed/simple; bh=0+qGrMf7S7EPRsJyFWnS5LEBEOo8FLK2sRP+XYy5S1M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fVOMKiJHShz1/In8PO8aHI9/eB7NNSkXa6sSFWmmcBeOqWuAQlcoZ5hWp2OQbpDdm9kPOk4BWMumPZd29aHmIg1en8IkQVDn06D0AQxcj/TzUhZqFt602O02gZEi+MrjL/FaLuh4nD080LUV7MRiB7pBB76RQ3yyfsCQhN6LqJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pPLh6WML; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pPLh6WML" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1648C4CEC3; Fri, 18 Oct 2024 19:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729278854; bh=0+qGrMf7S7EPRsJyFWnS5LEBEOo8FLK2sRP+XYy5S1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pPLh6WMLUkTmhlixixs1CCU1ccICGEJrhLvnHmlw0DGC4srkdOVnfmV0dkk+4QIVU jKj9WAod9XHB7mBIbUxjoVAIk1euyfaxsXX0juN+oafy92j9mf6N4HZTUDMjDidGWs KwkshWvI3xaT3MDXP30uPvJAXu2Vt6Rfkz7sRIrcOVcfZsw5MFurG8G3XRDQmLMuzz TXRLjSBQQt0peAJpR81Ve7rUOKA+h1RCOW8yLo54iftKyUTl4gIwcdqNevUMr6eSBJ yqA16vYe2GA90B4KlZA5rpZ3MqVoZaqGPvatUconKeUbL2Uz12kn2rNtAm+Jq8iKV4 KPkN8fGqW8BIA== Date: Fri, 18 Oct 2024 20:14:10 +0100 From: Simon Horman To: Heiner Kallweit Cc: Realtek linux nic maintainers , Andrew Lunn , Paolo Abeni , Jakub Kicinski , David Miller , Eric Dumazet , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] r8169: enable EEE at 2.5G per default on RTL8125B Message-ID: <20241018191410.GY1697@kernel.org> References: <95dd5a0c-09ea-4847-94d9-b7aa3063e8ff@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95dd5a0c-09ea-4847-94d9-b7aa3063e8ff@gmail.com> On Thu, Oct 17, 2024 at 10:27:44PM +0200, Heiner Kallweit wrote: > Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line > disables advertisement of EEE at 2.5G. Latest vendor driver r8125 > doesn't do this (any longer?), so this mode seems to be safe. > EEE saves quite some energy, therefore enable this mode per default. > > Signed-off-by: Heiner Kallweit Reviewed-by: Simon Horman