From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] lib: packing: create __pack() and __unpack() variants without error checking
Date: Sat, 19 Oct 2024 15:45:37 +0300 [thread overview]
Message-ID: <20241019124537.mzhrgg2dj4msrycx@skbuf> (raw)
In-Reply-To: <20241011-packing-pack-fields-and-ice-implementation-v1-1-d9b1f7500740@intel.com> <20241011-packing-pack-fields-and-ice-implementation-v1-1-d9b1f7500740@intel.com>
On Fri, Oct 11, 2024 at 11:48:29AM -0700, Jacob Keller wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> A future variant of the API, which works on arrays of packed_field
> structures, will make most of these checks redundant. The idea will be
> that we want to perform sanity checks only once at boot time, not once
> for every function call. So we need faster variants of pack() and
The "idea" changed between writing the commit message and the final
implementation. Can you restate "sanity checks only once at boot time"
and make it "sanity checks at compile time"?
> unpack(), which assume that the input was pre-sanitized.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
next prev parent reply other threads:[~2024-10-19 12:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 18:48 [PATCH net-next 0/8] lib: packing: introduce and use (un)pack_fields Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 1/8] lib: packing: create __pack() and __unpack() variants without error checking Jacob Keller
2024-10-14 14:27 ` Vladimir Oltean
2024-10-14 18:52 ` Jacob Keller
2024-10-19 12:45 ` Vladimir Oltean [this message]
2024-10-22 19:12 ` Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 2/8] lib: packing: demote truncation error in pack() to a warning in __pack() Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 3/8] lib: packing: add pack_fields() and unpack_fields() Jacob Keller
2024-10-15 19:19 ` Jacob Keller
2024-10-16 13:02 ` Przemek Kitszel
2024-10-16 13:40 ` Vladimir Oltean
2024-10-16 22:31 ` Keller, Jacob E
2024-10-18 21:50 ` Jacob Keller
2024-10-19 12:20 ` Vladimir Oltean
2024-10-22 19:11 ` Jacob Keller
2024-10-24 13:49 ` Vladimir Oltean
2024-10-24 16:38 ` Jacob Keller
2024-10-24 20:14 ` Jacob Keller
2024-10-24 20:30 ` Vladimir Oltean
2024-10-11 18:48 ` [PATCH net-next 4/8] ice: remove int_q_state from ice_tlan_ctx Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 5/8] ice: use <linux/packing.h> for Tx and Rx queue context data Jacob Keller
2024-10-19 13:39 ` Vladimir Oltean
2024-10-22 19:14 ` Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 6/8] ice: reduce size of queue context fields Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 7/8] ice: move prefetch enable to ice_setup_rx_ctx Jacob Keller
2024-10-11 18:48 ` [PATCH net-next 8/8] ice: cleanup Rx queue context programming functions Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019124537.mzhrgg2dj4msrycx@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.l.nguyen@intel.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox