Re: [PATCH net-next 3/8] lib: packing: add pack_fields() and unpack_fields()

Vladimir Oltean
2024-10-24T20:30:52Z

On Thu, Oct 24, 2024 at 01:14:21PM -0700, Jacob Keller wrote:
> On 10/24/2024 9:38 AM, Jacob Keller wrote:
> > I also have some thought about trying to catch this in a coccinelle
> > script. That has the trade-off that its only caught by running the
> > spatch/coccinelle scripts, but it would completely eliminate the need to
> > modify Kbuild at all.
> >
> > I'm going to try and experiment with that direction and see if its feasible.
> >
>
> Coccinelle can't handle all of the relevant checks, since it does not
> parse the macros, and can only look at the uncompiled code.
>
> I'll have a v2 out soon with Vladimir's suggested approach.
>
> Thanks,
> Jake

I should mention that my earlier patch is a big blob, but it should
really be broken down into little bits which are each squashed into
existing patches from this set, until nothing remains of it.