* [PATCH] selftests: tc-testing: Fixed Typo error
@ 2024-07-31 18:07 Karan Sanghavi
2024-08-01 18:24 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Karan Sanghavi @ 2024-07-31 18:07 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan,
Karan Sanghavi, netdev, linux-kselftest, linux-kernel
Cc: Karan Sanghavi
Corrected the typographical of the word "different"
in the "name" field of the JSON object with ID "4319".
Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
---
tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
index 03723cf84..6897ff5ad 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
@@ -1189,7 +1189,7 @@
},
{
"id": "4319",
- "name": "Replace cgroup filter with diffferent match",
+ "name": "Replace cgroup filter with different match",
"category": [
"filter",
"cgroup"
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] selftests: tc-testing: Fixed Typo error
@ 2024-07-31 18:09 Karan Sanghavi
0 siblings, 0 replies; 7+ messages in thread
From: Karan Sanghavi @ 2024-07-31 18:09 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan,
Karan Sanghavi, netdev, linux-kselftest, linux-kernel
Cc: Karan Sanghavi
Corrected the typographical of the word "multiple"
in the "name" field of the JSON object with ID "4341".
Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
---
tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
index 58189327f..996448afe 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
@@ -507,7 +507,7 @@
},
{
"id": "4341",
- "name": "Add flow filter with muliple ops",
+ "name": "Add flow filter with multiple ops",
"category": [
"filter",
"flow"
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: tc-testing: Fixed Typo error
@ 2024-07-31 22:07 Victor Nogueira
0 siblings, 0 replies; 7+ messages in thread
From: Victor Nogueira @ 2024-07-31 22:07 UTC (permalink / raw)
To: Karan Sanghavi, Jamal Hadi Salim, Cong Wang, Jiri Pirko,
Shuah Khan, netdev, linux-kselftest, linux-kernel
On 31/07/2024 15:07, Karan Sanghavi wrote:
> Corrected the typographical of the word "different"
> in the "name" field of the JSON object with ID "4319".
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
Thank you for the patch.
I'd suggest you transform this patch and the other one you sent, which
has the same subject, into a patch series.
Also please change the subject to target net-next and to specify which
test files your patches are touching.
cheers,
Victor
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: tc-testing: Fixed Typo error
2024-07-31 18:07 Karan Sanghavi
@ 2024-08-01 18:24 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2024-08-01 18:24 UTC (permalink / raw)
To: Karan Sanghavi
Cc: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan, netdev,
linux-kselftest, linux-kernel
On Wed, Jul 31, 2024 at 06:07:38PM +0000, Karan Sanghavi wrote:
> Corrected the typographical of the word "different"
> in the "name" field of the JSON object with ID "4319".
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
Thanks,
I checked an this is the item flagged by codespell in this file.
...
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] selftests: tc-testing: Fixed typo error
@ 2024-10-19 11:52 Karan Sanghavi
2024-10-19 18:17 ` Simon Horman
2024-10-21 20:20 ` Shuah Khan
0 siblings, 2 replies; 7+ messages in thread
From: Karan Sanghavi @ 2024-10-19 11:52 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan
Cc: netdev, linux-kselftest, linux-kernel, Shuah Khan, Anup,
Karan Sanghavi, Simon Horman
Corrected the multiple and different typo errors in json files
- "diffferent" is corrected to "different".
- "muliple" and "miltiple" is corrected to "multiple".
Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
---
tools/testing/selftests/tc-testing/tc-tests/filters/basic.json | 6 +++---
tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 6 +++---
tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
tools/testing/selftests/tc-testing/tc-tests/filters/route.json | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json b/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json
index d1278de8ebc3..c9309a44a87e 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/basic.json
@@ -67,7 +67,7 @@
},
{
"id": "4943",
- "name": "Add basic filter with cmp ematch u32/link layer and miltiple actions",
+ "name": "Add basic filter with cmp ematch u32/link layer and multiple actions",
"category": [
"filter",
"basic"
@@ -155,7 +155,7 @@
},
{
"id": "32d8",
- "name": "Add basic filter with cmp ematch u32/network layer and miltiple actions",
+ "name": "Add basic filter with cmp ematch u32/network layer and multiple actions",
"category": [
"filter",
"basic"
@@ -243,7 +243,7 @@
},
{
"id": "62d7",
- "name": "Add basic filter with cmp ematch u32/transport layer and miltiple actions",
+ "name": "Add basic filter with cmp ematch u32/transport layer and multiple actions",
"category": [
"filter",
"basic"
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
index 03723cf84379..35c9a7dbe1c4 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
@@ -67,7 +67,7 @@
},
{
"id": "0234",
- "name": "Add cgroup filter with cmp ematch u32/link layer and miltiple actions",
+ "name": "Add cgroup filter with cmp ematch u32/link layer and multiple actions",
"category": [
"filter",
"cgroup"
@@ -155,7 +155,7 @@
},
{
"id": "2733",
- "name": "Add cgroup filter with cmp ematch u32/network layer and miltiple actions",
+ "name": "Add cgroup filter with cmp ematch u32/network layer and multiple actions",
"category": [
"filter",
"cgroup"
@@ -1189,7 +1189,7 @@
},
{
"id": "4319",
- "name": "Replace cgroup filter with diffferent match",
+ "name": "Replace cgroup filter with different match",
"category": [
"filter",
"cgroup"
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
index 58189327f644..996448afe31b 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
@@ -507,7 +507,7 @@
},
{
"id": "4341",
- "name": "Add flow filter with muliple ops",
+ "name": "Add flow filter with multiple ops",
"category": [
"filter",
"flow"
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/route.json b/tools/testing/selftests/tc-testing/tc-tests/filters/route.json
index 8d8de8f65aef..05cedca67cca 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/route.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/route.json
@@ -111,7 +111,7 @@
},
{
"id": "7994",
- "name": "Add route filter with miltiple actions",
+ "name": "Add route filter with multiple actions",
"category": [
"filter",
"route"
---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241017-multiple_spell_error-8b267ffffe47
Best regards,
--
Karan Sanghavi <karansanghvi98@gmail.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: tc-testing: Fixed typo error
2024-10-19 11:52 [PATCH] selftests: tc-testing: Fixed typo error Karan Sanghavi
@ 2024-10-19 18:17 ` Simon Horman
2024-10-21 20:20 ` Shuah Khan
1 sibling, 0 replies; 7+ messages in thread
From: Simon Horman @ 2024-10-19 18:17 UTC (permalink / raw)
To: Karan Sanghavi
Cc: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Shuah Khan, netdev,
linux-kselftest, linux-kernel, Shuah Khan, Anup
On Sat, Oct 19, 2024 at 11:52:21AM +0000, Karan Sanghavi wrote:
> Corrected the multiple and different typo errors in json files
>
> - "diffferent" is corrected to "different".
> - "muliple" and "miltiple" is corrected to "multiple".
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
Thanks,
This addresses all the spelling errors in these files that
I see flagged by codespell.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: tc-testing: Fixed typo error
2024-10-19 11:52 [PATCH] selftests: tc-testing: Fixed typo error Karan Sanghavi
2024-10-19 18:17 ` Simon Horman
@ 2024-10-21 20:20 ` Shuah Khan
1 sibling, 0 replies; 7+ messages in thread
From: Shuah Khan @ 2024-10-21 20:20 UTC (permalink / raw)
To: Karan Sanghavi, Jamal Hadi Salim, Cong Wang, Jiri Pirko,
Shuah Khan
Cc: netdev, linux-kselftest, linux-kernel, Anup, Simon Horman,
Shuah Khan
On 10/19/24 05:52, Karan Sanghavi wrote:
> Corrected the multiple and different typo errors in json files
>
It should say "Correct or Fix" - Same comment in short log
"Fix" instead of "Fixed"
Do refer to commit for the subsystems and file to get an idea
on the convention.
> - "diffferent" is corrected to "different".
> - "muliple" and "miltiple" is corrected to "multiple".
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
> tools/testing/selftests/tc-testing/tc-tests/filters/basic.json | 6 +++---
> tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 6 +++---
> tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
> tools/testing/selftests/tc-testing/tc-tests/filters/route.json | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
Otherwise the changes look good to me. With the above change
to short and commit logs:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-21 20:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-19 11:52 [PATCH] selftests: tc-testing: Fixed typo error Karan Sanghavi
2024-10-19 18:17 ` Simon Horman
2024-10-21 20:20 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2024-07-31 22:07 [PATCH] selftests: tc-testing: Fixed Typo error Victor Nogueira
2024-07-31 18:09 Karan Sanghavi
2024-07-31 18:07 Karan Sanghavi
2024-08-01 18:24 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).