From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FC81E8825 for ; Mon, 21 Oct 2024 16:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729528804; cv=none; b=J+34oFJ7WJyEmsK/GtDTBQqAolc8CQ6upoNHej+oxxTmJMUxdJricpzRYQm0tJteWs7sCilIIityp/sg472YH50bdCpKMCNc6OMx+/Tq66jorNj+DuN5twoDQ82unsOntwY4Yx5/FrWIeQoYTCTMPJvLdWs8kTJIXaSRrrPqP3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729528804; c=relaxed/simple; bh=clBz4bxVyFr6lguTWfYs3z+VHb7CP7RgXSsjuX0vklM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rFoJJKlC9TbGdDW7u51ILyFBp5muY6AYj9y/KcRGQlpBhCm6+q56WU3JLx1BMh5rw1nC2EY8ky4uk4o0oYBfrsW8UTdv3BAQdxHD57lZlPrVRQ4dfUujST6XXzyxhdgR77N2VphfG2dnWVrkRlEiNt9AJSYUVw+Av0v2qt1sj7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zgi/Gl4m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zgi/Gl4m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56F69C4CEC3; Mon, 21 Oct 2024 16:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729528804; bh=clBz4bxVyFr6lguTWfYs3z+VHb7CP7RgXSsjuX0vklM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zgi/Gl4mrqn13Yi1LknwfE1hZZCLCYb826CzcYrYT1pqRf2xInNPsdjbuFgbTlss/ uP1dSnvqsSgNyKTcuHIWXCvzFneTYSx0qVA0JfDKbbskOZRnPZ5v2d/Gt3A/cf2uec jxi4kGWcudP1gR4xvPTobRN93E4cui3MznU1yaeP3hLHa3HE07dQey+hDHDtTFuHNz qFQw+RclMc3b6+dbbc6cngwj6YDW22kkKtjQbhh5lafeKesRstGEtVpU2S9qzjypMc tNv32TQN8rziL+qE3ULcaFzLJjZxdUpftghnW6p1b19WRwYIPW4qQMqr29lWqbn603 XyWvDrGlFSgYA== Date: Mon, 21 Oct 2024 17:39:55 +0100 From: Simon Horman To: David Arinzon Cc: David Miller , Jakub Kicinski , netdev@vger.kernel.org, Eric Dumazet , Paolo Abeni , "Woodhouse, David" , "Machulsky, Zorik" , "Matushevsky, Alexander" , Saeed Bshara , "Wilson, Matt" , "Liguori, Anthony" , "Bshara, Nafea" , "Schmeilin, Evgeny" , "Belgazal, Netanel" , "Saidi, Ali" , "Herrenschmidt, Benjamin" , "Kiyanovski, Arthur" , "Dagan, Noam" , "Bernstein, Amit" , "Agroskin, Shay" , "Abboud, Osama" , "Ostrovsky, Evgeny" , "Tabachnik, Ofir" , "Machnikowski, Maciek" Subject: Re: [PATCH v1 net-next 1/3] net: ena: Add PHC support in the ENA driver Message-ID: <20241021163955.GL402847@kernel.org> References: <20241021052011.591-1-darinzon@amazon.com> <20241021052011.591-2-darinzon@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241021052011.591-2-darinzon@amazon.com> On Mon, Oct 21, 2024 at 08:20:09AM +0300, David Arinzon wrote: > The ENA driver will be extended to support the new PHC feature using > ptp_clock interface [1]. this will provide timestamp reference for user > space to allow measuring time offset between the PHC and the system > clock in order to achieve nanosecond accuracy. > > [1] - https://www.kernel.org/doc/html/latest/driver-api/ptp.html > > Signed-off-by: Amit Bernstein > Signed-off-by: David Arinzon Hi David, As it looks like there will be a v2 anyway, please consider running this series, and in particular this patch, through: ./scripts/checkpatch.pl --strict --max-line-length=80 --codespell And please fix warnings it emits where that can be done without reducing readability and clarity. E.g. please don't split string literals across more than one line just to make lines short. Thanks!