* [PATCH -next] octeon_ep: Remove unneeded semicolon
@ 2024-10-22 6:34 Yang Li
2024-10-22 15:59 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2024-10-22 6:34 UTC (permalink / raw)
To: vburru, sedara, davem, kuba; +Cc: netdev, linux-kernel, Yang Li, Abaci Robot
This patch removes an unneeded semicolon after a while statement.
./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:381:2-3: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11430
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/ethernet/marvell/octeon_ep/octep_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c b/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c
index 8af75cb37c3e..d65d9572ffa6 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c
@@ -378,7 +378,7 @@ static void octep_oq_drop_rx(struct octep_oq *oq,
while (data_len > 0) {
octep_oq_next_pkt(oq, buff_info, read_idx, desc_used);
data_len -= oq->buffer_size;
- };
+ }
}
/**
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] octeon_ep: Remove unneeded semicolon
2024-10-22 6:34 [PATCH -next] octeon_ep: Remove unneeded semicolon Yang Li
@ 2024-10-22 15:59 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-10-22 15:59 UTC (permalink / raw)
To: Yang Li; +Cc: vburru, sedara, davem, kuba, netdev, linux-kernel, Abaci Robot
On Tue, Oct 22, 2024 at 02:34:53PM +0800, Yang Li wrote:
> This patch removes an unneeded semicolon after a while statement.
>
> ./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:381:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11430
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Hi Yang Li,
While I agree that this change is correct, and improves the code.
Netdev discourages clean-ups along these lines that are not in
the context of other work [1].
[1] https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: not-applicable
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-22 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-22 6:34 [PATCH -next] octeon_ep: Remove unneeded semicolon Yang Li
2024-10-22 15:59 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).