From: Simon Horman <horms@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 1/2] PCI: Add PCI_VDEVICE_SUB helper macro
Date: Tue, 22 Oct 2024 17:04:28 +0100 [thread overview]
Message-ID: <20241022160428.GA402847@kernel.org> (raw)
In-Reply-To: <20241022153011.GA879691@bhelgaas>
On Tue, Oct 22, 2024 at 10:30:11AM -0500, Bjorn Helgaas wrote:
> On Mon, Oct 21, 2024 at 04:46:54PM +0200, Piotr Kwapulinski wrote:
> > PCI_VDEVICE_SUB generates the pci_device_id struct layout for
> > the specific PCI device/subdevice. Private data may follow the
> > output.
> >
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> > Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
>
> This looks OK to me but needs to be included in a series that uses it.
> I looked this message up on lore but can't find the 2/2 patch that
> presumably uses it.
>
> If 2/2 uses this,
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Hi Bjorn,
The threading of this patch-set does seem somehow broken.
But, FWIIW, I believe that patch 2/2 is here:
- [PATCH iwl-next v2 2/2] ixgbevf: Add support for Intel(R) E610 device
https://lore.kernel.org/netdev/20241021144841.5476-1-piotr.kwapulinski@intel.com/
next prev parent reply other threads:[~2024-10-22 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 14:46 [PATCH iwl-next v2 1/2] PCI: Add PCI_VDEVICE_SUB helper macro Piotr Kwapulinski
2024-10-22 15:30 ` [Intel-wired-lan] " Bjorn Helgaas
2024-10-22 16:04 ` Simon Horman [this message]
2024-10-30 8:18 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022160428.GA402847@kernel.org \
--to=horms@kernel.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=piotr.kwapulinski@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).