netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris H <christopher.s.hall@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: david.zage@intel.com, vinicius.gomes@intel.com,
	netdev@vger.kernel.org, rodrigo.cadore@l-acoustics.com,
	vinschen@redhat.com
Subject: [PATCH iwl-net v2 0/4] igc: Fix PTM timeout
Date: Wed, 23 Oct 2024 02:30:36 +0000	[thread overview]
Message-ID: <20241023023040.111429-1-christopher.s.hall@intel.com> (raw)

There have been sporadic reports of PTM timeouts using i225/i226 devices

These timeouts have been root caused to:

1) Manipulating the PTM status register while PTM is enabled and triggered
2) The hardware retrying too quickly when an inappropriate response is
   received from the upstream device

The issue can be reproduced with the following:

$ sudo phc2sys -R 1000 -O 0 -i tsn0 -m

Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to
quickly reproduce the issue.

PHC2SYS exits with:

"ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction
  fails

Changelog:

v1 -> v2: -Removed patch modifying PTM retry loop count
      	  -Moved PTM mutex initialization from igc_reset() to igc_ptp_init()
	   called once in igc_probe()


Christopher S M Hall (4):
  igc: Ensure the PTM cycle is reliably triggered
  igc: Lengthen the hardware retry time to prevent timeouts
  igc: Move ktime snapshot into PTM retry loop
  igc: Add lock preventing multiple simultaneous PTM transactions

 drivers/net/ethernet/intel/igc/igc.h         |  1 +
 drivers/net/ethernet/intel/igc/igc_defines.h |  3 +-
 drivers/net/ethernet/intel/igc/igc_ptp.c     | 98 ++++++++++++--------
 3 files changed, 62 insertions(+), 40 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-10-23  2:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  2:30 Chris H [this message]
2024-10-23  2:30 ` [PATCH iwl-net v2 1/4] igc: Ensure the PTM cycle is reliably triggered Chris H
2024-10-29 21:21   ` Tony Nguyen
2024-10-30 10:17   ` Corinna Vinschen
2024-10-31  9:34   ` [Intel-wired-lan] " Avigail Dahan
2024-10-23  2:30 ` [PATCH iwl-net v2 2/4] igc: Lengthen the hardware retry time to prevent timeouts Chris H
2024-10-31  9:35   ` [Intel-wired-lan] " Avigail Dahan
2024-10-23  2:30 ` [PATCH iwl-net v2 3/4] igc: Move ktime snapshot into PTM retry loop Chris H
2024-10-31  9:35   ` [Intel-wired-lan] " Mor Bar-Gabay
2024-10-23  2:30 ` [PATCH iwl-net v2 4/4] igc: Add lock preventing multiple simultaneous PTM transactions Chris H
2024-10-29 21:20   ` Tony Nguyen
2024-10-30 10:20   ` Corinna Vinschen
2024-10-31  9:36   ` [Intel-wired-lan] " Mor Bar-Gabay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023023040.111429-1-christopher.s.hall@intel.com \
    --to=christopher.s.hall@intel.com \
    --cc=david.zage@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=rodrigo.cadore@l-acoustics.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).