netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris H <christopher.s.hall@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: david.zage@intel.com, vinicius.gomes@intel.com,
	netdev@vger.kernel.org, rodrigo.cadore@l-acoustics.com,
	vinschen@redhat.com,
	Christopher S M Hall <christopher.s.hall@intel.com>
Subject: [PATCH iwl-net v2 2/4] igc: Lengthen the hardware retry time to prevent timeouts
Date: Wed, 23 Oct 2024 02:30:38 +0000	[thread overview]
Message-ID: <20241023023040.111429-3-christopher.s.hall@intel.com> (raw)
In-Reply-To: <20241023023040.111429-1-christopher.s.hall@intel.com>

From: Christopher S M Hall <christopher.s.hall@intel.com>

Lengthen the hardware retry timer to four microseconds.

The i225/i226 hardware retries if it receives an inappropriate response
from the upstream device. If the device retries too quickly, the root
port does not respond.

The issue can be reproduced with the following:

$ sudo phc2sys -R 1000 -O 0 -i tsn0 -m

Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to
quickly reproduce the issue.

PHC2SYS exits with:

"ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction
  fails

Fixes: 6b8aa753a9f9 ("igc: Decrease PTM short interval from 10 us to 1 us")
Signed-off-by: Christopher S M Hall <christopher.s.hall@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h
index afd0512dc9f8..58bd9dbbdf43 100644
--- a/drivers/net/ethernet/intel/igc/igc_defines.h
+++ b/drivers/net/ethernet/intel/igc/igc_defines.h
@@ -574,7 +574,7 @@
 #define IGC_PTM_CTRL_SHRT_CYC(usec)	(((usec) & 0x3f) << 2)
 #define IGC_PTM_CTRL_PTM_TO(usec)	(((usec) & 0xff) << 8)
 
-#define IGC_PTM_SHORT_CYC_DEFAULT	1   /* Default short cycle interval */
+#define IGC_PTM_SHORT_CYC_DEFAULT	4   /* Default short cycle interval */
 #define IGC_PTM_CYC_TIME_DEFAULT	5   /* Default PTM cycle time */
 #define IGC_PTM_TIMEOUT_DEFAULT		255 /* Default timeout for PTM errors */
 
-- 
2.34.1


  parent reply	other threads:[~2024-10-23  2:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  2:30 [PATCH iwl-net v2 0/4] igc: Fix PTM timeout Chris H
2024-10-23  2:30 ` [PATCH iwl-net v2 1/4] igc: Ensure the PTM cycle is reliably triggered Chris H
2024-10-29 21:21   ` Tony Nguyen
2024-10-30 10:17   ` Corinna Vinschen
2024-10-31  9:34   ` [Intel-wired-lan] " Avigail Dahan
2024-10-23  2:30 ` Chris H [this message]
2024-10-31  9:35   ` [Intel-wired-lan] [PATCH iwl-net v2 2/4] igc: Lengthen the hardware retry time to prevent timeouts Avigail Dahan
2024-10-23  2:30 ` [PATCH iwl-net v2 3/4] igc: Move ktime snapshot into PTM retry loop Chris H
2024-10-31  9:35   ` [Intel-wired-lan] " Mor Bar-Gabay
2024-10-23  2:30 ` [PATCH iwl-net v2 4/4] igc: Add lock preventing multiple simultaneous PTM transactions Chris H
2024-10-29 21:20   ` Tony Nguyen
2024-10-30 10:20   ` Corinna Vinschen
2024-10-31  9:36   ` [Intel-wired-lan] " Mor Bar-Gabay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023023040.111429-3-christopher.s.hall@intel.com \
    --to=christopher.s.hall@intel.com \
    --cc=david.zage@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=rodrigo.cadore@l-acoustics.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).