From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <gnaaman@drivenets.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <stfomichev@gmail.com>
Subject: Re: [PATCH net-next v7 0/6] neighbour: Improve neigh_flush_dev performance
Date: Tue, 22 Oct 2024 22:18:11 -0700 [thread overview]
Message-ID: <20241023051811.37782-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241023050110.3509553-1-gnaaman@drivenets.com>
From: Gilad Naaman <gnaaman@drivenets.com>
Date: Wed, 23 Oct 2024 05:01:10 +0000
> > Looks like the test is still unhappy. Can you try to run it on your side
> > before reposting? Or does it look good?
>
> Hey,
>
> Apologies if I missed anything.
>
> I ran this before posting, after applying the entire series, and found no crashes:
>
> sudo make -C tools/testing/selftests run_tests TARGETS=net
>
> Is there more info about this run?
> Was this ran on an intermediate patch in the series or all of it?
It seems the warning requires CONFIG_DEBUG_VM.
[ 110.446754][ C2] kernel BUG at include/linux/mm.h:1140!
But I guess the issue will disappear if you rebase the series on top of
Eric's patch and avoid calling free_pages() directly ?
https://lore.kernel.org/netdev/20241022150059.1345406-1-edumazet@google.com/
next prev parent reply other threads:[~2024-10-23 5:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 13:43 [PATCH net-next v7 0/6] neighbour: Improve neigh_flush_dev performance Gilad Naaman
2024-10-22 13:43 ` [PATCH net-next v7 1/6] neighbour: Add hlist_node to struct neighbour Gilad Naaman
2024-10-22 14:40 ` Eric Dumazet
2024-10-23 5:16 ` Gilad Naaman
2024-10-22 13:43 ` [PATCH net-next v7 2/6] neighbour: Define neigh_for_each_in_bucket Gilad Naaman
2024-10-22 13:43 ` [PATCH net-next v7 3/6] neighbour: Convert seq_file functions to use hlist Gilad Naaman
2024-10-22 13:43 ` [PATCH net-next v7 4/6] neighbour: Convert iteration to use hlist+macro Gilad Naaman
2024-10-22 13:43 ` [PATCH net-next v7 5/6] neighbour: Remove bare neighbour::next pointer Gilad Naaman
2024-10-22 13:43 ` [PATCH net-next v7 6/6] neighbour: Create netdev->neighbour association Gilad Naaman
2024-10-22 23:48 ` [PATCH net-next v7 0/6] neighbour: Improve neigh_flush_dev performance Stanislav Fomichev
2024-10-23 5:01 ` Gilad Naaman
2024-10-23 5:18 ` Kuniyuki Iwashima [this message]
2024-10-23 5:38 ` Gilad Naaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023051811.37782-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnaaman@drivenets.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).