From: Stephen Hemminger <stephen@networkplumber.org>
To: chia-yu.chang@nokia-bell-labs.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com, davem@davemloft.net,
jhs@mojatatu.com, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, ij@kernel.org,
ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
g.white@CableLabs.com, ingemar.s.johansson@ericsson.com,
mirja.kuehlewind@ericsson.com, cheshire@apple.com,
rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com, Olga Albisser <olga@albisser.org>,
Oliver Tilmans <olivier.tilmans@nokia.com>,
Bob Briscoe <research@bobbriscoe.net>,
Henrik Steen <henrist@henrist.net>
Subject: Re: [PATCH v2 iproute2-next 1/1] tc: add dualpi2 scheduler module
Date: Wed, 23 Oct 2024 08:54:23 -0700 [thread overview]
Message-ID: <20241023085423.7e842346@hermes.local> (raw)
In-Reply-To: <20241023110434.65194-2-chia-yu.chang@nokia-bell-labs.com>
On Wed, 23 Oct 2024 13:04:34 +0200
chia-yu.chang@nokia-bell-labs.com wrote:
> + if (tb[TCA_DUALPI2_ALPHA] &&
> + RTA_PAYLOAD(tb[TCA_DUALPI2_ALPHA]) >= sizeof(__u32))
> + print_float(PRINT_ANY, "alpha", "alpha %f ",
> + ((float)rta_getattr_u32(tb[TCA_DUALPI2_ALPHA])) /
> + ALPHA_BETA_SCALE);
Since this is repeated maybe a simple helper function
get_scaled_alpha(tb[TCA_DUALPI2_ALPHA])
next prev parent reply other threads:[~2024-10-23 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 11:04 [PATCH v2 iproute2-next 0/1] DualPI2 iproute2 patch chia-yu.chang
2024-10-23 11:04 ` [PATCH v2 iproute2-next 1/1] tc: add dualpi2 scheduler module chia-yu.chang
2024-10-23 15:52 ` Stephen Hemminger
2024-10-23 17:50 ` Chia-Yu Chang (Nokia)
2024-10-23 19:47 ` Ilpo Järvinen
2024-10-23 21:09 ` Stephen Hemminger
2024-10-23 15:54 ` Stephen Hemminger [this message]
2024-10-23 15:55 ` Stephen Hemminger
2024-10-23 16:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023085423.7e842346@hermes.local \
--to=stephen@networkplumber.org \
--cc=Jason_Livingood@comcast.com \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=g.white@CableLabs.com \
--cc=henrist@henrist.net \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=olga@albisser.org \
--cc=olivier.tilmans@nokia.com \
--cc=pabeni@redhat.com \
--cc=research@bobbriscoe.net \
--cc=rs.ietf@gmx.at \
--cc=vidhi_goel@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).