From: Simon Horman <horms@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Vladimir Oltean <vladimir.oltean@nxp.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT:" <llvm@lists.linux.dev>
Subject: Re: [PATCH net-next v2 2/2] net: systemport: Move IO macros to header file
Date: Wed, 23 Oct 2024 19:42:28 +0100 [thread overview]
Message-ID: <20241023184228.GB402847@kernel.org> (raw)
In-Reply-To: <20241021174935.57658-3-florian.fainelli@broadcom.com>
On Mon, Oct 21, 2024 at 10:49:35AM -0700, Florian Fainelli wrote:
> Move the BCM_SYSPORT_IO_MACRO() definition and its use to bcmsysport.h
> where it is more appropriate and where static inline helpers are
> acceptable. While at it, make sure that the macro 'offset' argument does
> not trigger a checkpatch warning due to possible argument re-use.
>
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-23 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 17:49 [PATCH net-next v2 0/2] net: systemport: Minor IO macros changes Florian Fainelli
2024-10-21 17:49 ` [PATCH net-next v2 1/2] net: systemport: Remove unused txchk accessors Florian Fainelli
2024-10-23 18:42 ` Simon Horman
2024-10-21 17:49 ` [PATCH net-next v2 2/2] net: systemport: Move IO macros to header file Florian Fainelli
2024-10-23 18:42 ` Simon Horman [this message]
2024-10-28 23:00 ` [PATCH net-next v2 0/2] net: systemport: Minor IO macros changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023184228.GB402847@kernel.org \
--to=horms@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).