From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 998192003CD for ; Thu, 24 Oct 2024 14:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729779661; cv=none; b=YrkfYXr3nGQpwPHFBzcyJh69BbYhC58gn/sAuO+OcDtzwZrAsiJoRDOLBk+zQmBYqJyCv2R8AS+QFO7v6/bX1934WSXkRjpVUpOpdOyvCgCk2oqQo48XUfIKrClD625FPU9fADEHEWzA/9q4d5H2seGHgLf7RJHNQ4dhkKbFMHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729779661; c=relaxed/simple; bh=CeH6d9jYHaUoXOEafD41IQtDoDuY9WGiGrn3lPFqJ9E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ux553EZfpNB27gFrYfmHk4TYbyh8AfX55+KuC/cGvRaMf85jI9LkRfiUtRImp1Gz0yz2/QhOjjO3T5PdHiMiyo9shSzfvvPDge9askdYLsljaYW1E+ngEMRvoeOvDT0RrsbFsekamnM5rGCQQAI5dL/8rhuXY1gVg5zs3CNyNOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3yhJ-000452-8g; Thu, 24 Oct 2024 16:20:21 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t3yhI-000DEt-35; Thu, 24 Oct 2024 16:20:20 +0200 Received: from pengutronix.de (pd9e595f8.dip0.t-ipconnect.de [217.229.149.248]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 8119C35DCED; Thu, 24 Oct 2024 14:20:20 +0000 (UTC) Date: Thu, 24 Oct 2024 16:20:20 +0200 From: Marc Kleine-Budde To: Ming Yu Cc: tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, andi.shyti@kernel.org, mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net, jdelvare@suse.com, jic23@kernel.org, lars@metafoo.de, ukleinek@kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1 4/9] can: Add Nuvoton NCT6694 CAN support Message-ID: <20241024-cryptic-giga-mole-54e2b5-mkl@pengutronix.de> References: <20241024085922.133071-1-tmyu0@nuvoton.com> <20241024085922.133071-5-tmyu0@nuvoton.com> <20241024-poetic-offbeat-alligator-d6b9fe-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="umhghwnwqoavy3lt" Content-Disposition: inline In-Reply-To: <20241024-poetic-offbeat-alligator-d6b9fe-mkl@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org --umhghwnwqoavy3lt Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/9] can: Add Nuvoton NCT6694 CAN support MIME-Version: 1.0 On 24.10.2024 16:17:52, Marc Kleine-Budde wrote: > On 24.10.2024 16:59:17, Ming Yu wrote: > > This driver supports Socket CANfd functionality for NCT6694 MFD > > device based on USB interface. > >=20 > > Signed-off-by: Ming Yu > > --- > > MAINTAINERS | 1 + > > drivers/net/can/Kconfig | 10 + > > drivers/net/can/Makefile | 1 + > > drivers/net/can/nct6694_canfd.c | 843 ++++++++++++++++++++++++++++++++ | CC [M] drivers/net/can/nct6694_canfd.o | drivers/net/can/nct6694_canfd.c: In function =E2=80=98nct6694_canfd_start= _xmit=E2=80=99: | drivers/net/can/nct6694_canfd.c:282:22: error: variable =E2=80=98echo_byt= e=E2=80=99 set but not used [-Werror=3Dunused-but-set-variable] | 282 | unsigned int echo_byte; | | ^~~~~~~~~ | drivers/net/can/nct6694_canfd.c: In function =E2=80=98nct6694_canfd_rx_wo= rk=E2=80=99: | drivers/net/can/nct6694_canfd.c:677:34: error: variable =E2=80=98stats=E2= =80=99 set but not used [-Werror=3Dunused-but-set-variable] | 677 | struct net_device_stats *stats; | | ^~~~~ | cc1: all warnings being treated as errors If compiling with C=3D1, sparse throws the following errors: | drivers/net/can/nct6694_canfd.c:417:14: warning: cast to restricted __le32 | drivers/net/can/nct6694_canfd.c:750:9: warning: cast to restricted __le32 | drivers/net/can/nct6694_canfd.c:777:32: warning: cast to restricted __le32 Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --umhghwnwqoavy3lt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmcaV6EACgkQKDiiPnot vG+E+Qf8CIIlMRqAUgax6FgoXWP0LDl3JVfJSfoClGvwvTGIR6r0hAAYhY6YXdy9 gUPusFE69CRe780ZIu4/gR45YWIRpof1exG4JAIoKbU/4Bdq/42x1BKSXifWPayo Rm/mm+HyVCjb7WTpopxM7ZCnZMks9xOUwl6A+/ShIRZA3pWBz8ll4yRCtTq1V6xy GMKhYsYP4mDY3YyD1+hUfLBmiBu2XvhnGksdoLRZHNMNKlNhZnpRSLeQew5EHSy1 03BltphJ6YsdAgTfyR7AT4nTisdNyYl+IhnJq1+FSKsWxdHcelNMaM3JwlLrXMBO FbotT17CV8J3M14xFrwqL7cRROi57A== =lV4A -----END PGP SIGNATURE----- --umhghwnwqoavy3lt--