netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Fang <wei.fang@nxp.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, vladimir.oltean@nxp.com,
	claudiu.manoil@nxp.com, xiaoning.wang@nxp.com, Frank.Li@nxp.com,
	christophe.leroy@csgroup.eu, linux@armlinux.org.uk,
	bhelgaas@google.com, horms@kernel.org
Cc: imx@lists.linux.dev, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, alexander.stein@ew.tq-group.com
Subject: [PATCH v5 net-next 11/13] net: enetc: optimize the allocation of tx_bdr
Date: Thu, 24 Oct 2024 14:53:26 +0800	[thread overview]
Message-ID: <20241024065328.521518-12-wei.fang@nxp.com> (raw)
In-Reply-To: <20241024065328.521518-1-wei.fang@nxp.com>

From: Clark Wang <xiaoning.wang@nxp.com>

There is a situation where num_tx_rings cannot be divided by bdr_int_num.
For example, num_tx_rings is 8 and bdr_int_num is 3. According to the
previous logic, this results in two tx_bdr corresponding memories not
being allocated, so when sending packets to tx ring 6 or 7, wild pointers
will be accessed. Of course, this issue doesn't exist on LS1028A, because
its num_tx_rings is 8, and bdr_int_num is either 1 or 2. However, there
is a risk for the upcoming i.MX95. Therefore, it is necessary to ensure
that each tx_bdr can be allocated to the corresponding memory.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
v5: no changes
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index bd725561b8a2..bccbeb1f355c 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -3049,10 +3049,10 @@ static void enetc_int_vector_destroy(struct enetc_ndev_priv *priv, int i)
 int enetc_alloc_msix(struct enetc_ndev_priv *priv)
 {
 	struct pci_dev *pdev = priv->si->pdev;
+	int v_tx_rings, v_remainder;
 	int num_stack_tx_queues;
 	int first_xdp_tx_ring;
 	int i, n, err, nvec;
-	int v_tx_rings;
 
 	nvec = ENETC_BDR_INT_BASE_IDX + priv->bdr_int_num;
 	/* allocate MSIX for both messaging and Rx/Tx interrupts */
@@ -3066,9 +3066,12 @@ int enetc_alloc_msix(struct enetc_ndev_priv *priv)
 
 	/* # of tx rings per int vector */
 	v_tx_rings = priv->num_tx_rings / priv->bdr_int_num;
+	v_remainder = priv->num_tx_rings % priv->bdr_int_num;
 
 	for (i = 0; i < priv->bdr_int_num; i++) {
-		err = enetc_int_vector_init(priv, i, v_tx_rings);
+		int num_tx_rings = i < v_remainder ? v_tx_rings + 1 : v_tx_rings;
+
+		err = enetc_int_vector_init(priv, i, num_tx_rings);
 		if (err)
 			goto fail;
 	}
-- 
2.34.1


  parent reply	other threads:[~2024-10-24  7:09 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24  6:53 [PATCH v5 net-next 00/13] add basic support for i.MX95 NETC Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 01/13] dt-bindings: net: add compatible string for i.MX95 EMDIO Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 02/13] dt-bindings: net: add i.MX95 ENETC support Wei Fang
2024-10-25 14:07   ` Rob Herring
2024-10-26  3:24     ` Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 03/13] dt-bindings: net: add bindings for NETC blocks control Wei Fang
2024-10-25 14:08   ` Rob Herring (Arm)
2024-10-24  6:53 ` [PATCH v5 net-next 04/13] net: enetc: add initial netc-blk-ctrl driver support Wei Fang
2024-10-24 16:27   ` Vladimir Oltean
2024-10-25  1:44     ` Wei Fang
2024-10-25 12:43       ` Vladimir Oltean
2024-10-26  2:47         ` Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 05/13] net: enetc: extract common ENETC PF parts for LS1028A and i.MX95 platforms Wei Fang
2024-10-24 16:38   ` Vladimir Oltean
2024-10-25  2:24     ` Wei Fang
2024-10-26  1:34   ` kernel test robot
2024-10-24  6:53 ` [PATCH v5 net-next 06/13] net: enetc: build enetc_pf_common.c as a separate module Wei Fang
2024-10-24 17:34   ` Vladimir Oltean
2024-10-25  3:00     ` Wei Fang
2024-10-25 13:23       ` Vladimir Oltean
2024-10-26  3:23         ` Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 07/13] net: enetc: remove ERR050089 workaround for i.MX95 Wei Fang
2024-10-24 17:51   ` Vladimir Oltean
2024-10-25  3:04     ` Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 08/13] PCI: Add NXP NETC vendor ID and device IDs Wei Fang
2024-10-24 18:16   ` Bjorn Helgaas
2024-10-25  3:13     ` Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 09/13] net: enetc: add i.MX95 EMDIO support Wei Fang
2024-10-24 18:00   ` Vladimir Oltean
2024-10-25  3:12     ` Wei Fang
2024-10-24 18:01   ` Vladimir Oltean
2024-10-24  6:53 ` [PATCH v5 net-next 10/13] net: enetc: extract enetc_int_vector_init/destroy() from enetc_alloc_msix() Wei Fang
2024-10-24 20:50   ` Vladimir Oltean
2024-10-25  3:27     ` Wei Fang
2024-10-24  6:53 ` Wei Fang [this message]
2024-10-25  9:51   ` [PATCH v5 net-next 11/13] net: enetc: optimize the allocation of tx_bdr Vladimir Oltean
2024-10-26  2:37     ` Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 12/13] net: enetc: add preliminary support for i.MX95 ENETC PF Wei Fang
2024-10-24  6:53 ` [PATCH v5 net-next 13/13] MAINTAINERS: update ENETC driver files and maintainers Wei Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241024065328.521518-12-wei.fang@nxp.com \
    --to=wei.fang@nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=bhelgaas@google.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=claudiu.manoil@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).