Re: [PATCH v1 3/9] i2c: Add Nuvoton NCT6694 I2C support

游子民
2024-10-25T07:47:16Z

Sorry, resending this email in plain text format.

Dear Andi,

Thank you for your comments.

Andi Shyti <andi.shyti@kernel.org> 於 2024年10月24日 週四 下午6:41寫道：
>
> Hi Ming,
>
> ...
>
> > +static int __init nct6694_init(void)
> > +{
> > + int err;
> > +
> > + err = platform_driver_register(&nct6694_i2c_driver);
> > + if (!err) {
> > + if (err)
> > + platform_driver_unregister(&nct6694_i2c_driver);
> > + }
> > +
> > + return err;
> > +}
> > +subsys_initcall(nct6694_init);
> > +
> > +static void __exit nct6694_exit(void)
> > +{
> > + platform_driver_unregister(&nct6694_i2c_driver);
> > +}
> > +module_exit(nct6694_exit);
>
> Have you thought about using auxiliary driver here?
> (auxiliary_bus.h)

[Ming] For platform driver registration, I'll change it to
module_platform_driver()
in the next patch.

>
> Thanks,
> Andi