Re: [PATCH v1 5/9] watchdog: Add Nuvoton NCT6694 WDT support

Guenter Roeck
2024-10-24T16:06:51Z

On 10/24/24 01:59, Ming Yu wrote:
> This driver supports Watchdog timer functionality for NCT6694 MFD
> device based on USB interface.
>
> Signed-off-by: Ming Yu <tmyu0@nuvoton.com>
> ---
[ ... ]

> +
> +static int nct6694_wdt_start(struct watchdog_device *wdev)
> +{
> + struct nct6694_wdt_data *data = watchdog_get_drvdata(wdev);
> +
> + pr_debug("%s: WDT(%d) Start\n", __func__, data->wdev_idx);
> +
> + return 0;
> +}
> +

That doesn't make sense. How is the watchdog started if not here ?
Something is conceptually wrong.

Guenter