From: Simon Horman <horms@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
thomas.petazzoni@bootlin.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next] Documentation: networking: Add missing PHY_GET command in the message list
Date: Thu, 24 Oct 2024 15:52:23 +0100 [thread overview]
Message-ID: <20241024145223.GR1202098@kernel.org> (raw)
In-Reply-To: <20241023141559.100973-1-kory.maincent@bootlin.com>
On Wed, Oct 23, 2024 at 04:15:58PM +0200, Kory Maincent wrote:
> ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
> Add it to the ethool netlink documentation.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Documentation/networking/ethtool-netlink.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index 295563e91082..70ecc3821007 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -236,6 +236,7 @@ Userspace to kernel:
> ``ETHTOOL_MSG_MM_GET`` get MAC merge layer state
> ``ETHTOOL_MSG_MM_SET`` set MAC merge layer parameters
> ``ETHTOOL_MSG_MODULE_FW_FLASH_ACT`` flash transceiver module firmware
> + ``ETHTOOL_MSG_PHY_GET`` get Ethernet PHY information
> ===================================== =================================
>
> Kernel to userspace:
> @@ -283,6 +284,8 @@ Kernel to userspace:
> ``ETHTOOL_MSG_PLCA_NTF`` PLCA RS parameters
> ``ETHTOOL_MSG_MM_GET_REPLY`` MAC merge layer status
> ``ETHTOOL_MSG_MODULE_FW_FLASH_NTF`` transceiver module flash updates
> + ``ETHTOOL_MSG_PHY_GET_REPLY`` Ethernet PHY information
> + ``ETHTOOL_MSG_PHY_NTF`` Ethernet PHY information
I wonder if ETHTOOL_MSG_PHY_NTF should be removed.
It doesn't seem to be used anywhere.
> ======================================== =================================
>
> ``GET`` requests are sent by userspace applications to retrieve device
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2024-10-24 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 14:15 [PATCH net-next] Documentation: networking: Add missing PHY_GET command in the message list Kory Maincent
2024-10-24 14:52 ` Simon Horman [this message]
2024-10-24 15:18 ` Kory Maincent
2024-10-24 15:28 ` Simon Horman
2024-10-24 16:11 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024145223.GR1202098@kernel.org \
--to=horms@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).