* [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp"
@ 2024-10-23 16:48 Caleb Sander Mateos
2024-10-24 15:08 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Caleb Sander Mateos @ 2024-10-23 16:48 UTC (permalink / raw)
To: Saeed Mahameed, Tariq Toukan, Leon Romanovsky, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Caleb Sander Mateos, netdev, linux-rdma, linux-kernel
"enahnced" looks to be a misspelling of "enhanced".
Rename "mlx5_cqwq_get_cqe_enahnced_comp" to
"mlx5_cqwq_get_cqe_enhanced_comp".
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 4 ++--
drivers/net/ethernet/mellanox/mlx5/core/wq.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index e601324a690a..604c0a72aa6c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -1124,11 +1124,11 @@ static void mlx5e_flush_rq_cq(struct mlx5e_rq *rq)
{
struct mlx5_cqwq *cqwq = &rq->cq.wq;
struct mlx5_cqe64 *cqe;
if (test_bit(MLX5E_RQ_STATE_MINI_CQE_ENHANCED, &rq->state)) {
- while ((cqe = mlx5_cqwq_get_cqe_enahnced_comp(cqwq)))
+ while ((cqe = mlx5_cqwq_get_cqe_enhanced_comp(cqwq)))
mlx5_cqwq_pop(cqwq);
} else {
while ((cqe = mlx5_cqwq_get_cqe(cqwq)))
mlx5_cqwq_pop(cqwq);
}
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
index 8e24ba96c779..d81083f4f316 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
@@ -2434,11 +2434,11 @@ static int mlx5e_rx_cq_process_enhanced_cqe_comp(struct mlx5e_rq *rq,
{
struct mlx5_cqe64 *cqe, *title_cqe = NULL;
struct mlx5e_cq_decomp *cqd = &rq->cqd;
int work_done = 0;
- cqe = mlx5_cqwq_get_cqe_enahnced_comp(cqwq);
+ cqe = mlx5_cqwq_get_cqe_enhanced_comp(cqwq);
if (!cqe)
return work_done;
if (cqd->last_cqe_title &&
(mlx5_get_cqe_format(cqe) == MLX5_COMPRESSED)) {
@@ -2464,11 +2464,11 @@ static int mlx5e_rx_cq_process_enhanced_cqe_comp(struct mlx5e_rq *rq,
INDIRECT_CALL_3(rq->handle_rx_cqe, mlx5e_handle_rx_cqe_mpwrq,
mlx5e_handle_rx_cqe, mlx5e_handle_rx_cqe_mpwrq_shampo,
rq, cqe);
work_done++;
} while (work_done < budget_rem &&
- (cqe = mlx5_cqwq_get_cqe_enahnced_comp(cqwq)));
+ (cqe = mlx5_cqwq_get_cqe_enhanced_comp(cqwq)));
/* last cqe might be title on next poll bulk */
if (title_cqe) {
mlx5e_read_enhanced_title_slot(rq, title_cqe);
cqd->last_cqe_title = true;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.h b/drivers/net/ethernet/mellanox/mlx5/core/wq.h
index e4ef1d24a3ad..6debb8fd33ff 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/wq.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/wq.h
@@ -242,11 +242,11 @@ static inline struct mlx5_cqe64 *mlx5_cqwq_get_cqe(struct mlx5_cqwq *wq)
return cqe;
}
static inline
-struct mlx5_cqe64 *mlx5_cqwq_get_cqe_enahnced_comp(struct mlx5_cqwq *wq)
+struct mlx5_cqe64 *mlx5_cqwq_get_cqe_enhanced_comp(struct mlx5_cqwq *wq)
{
u8 sw_validity_iteration_count = mlx5_cqwq_get_wrap_cnt(wq) & 0xff;
u32 ci = mlx5_cqwq_get_ci(wq);
struct mlx5_cqe64 *cqe;
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp"
2024-10-23 16:48 [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp" Caleb Sander Mateos
@ 2024-10-24 15:08 ` Simon Horman
2024-10-24 16:51 ` Tariq Toukan
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2024-10-24 15:08 UTC (permalink / raw)
To: Caleb Sander Mateos
Cc: Saeed Mahameed, Tariq Toukan, Leon Romanovsky, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-rdma, linux-kernel
On Wed, Oct 23, 2024 at 10:48:38AM -0600, Caleb Sander Mateos wrote:
> "enahnced" looks to be a misspelling of "enhanced".
> Rename "mlx5_cqwq_get_cqe_enahnced_comp" to
> "mlx5_cqwq_get_cqe_enhanced_comp".
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp"
2024-10-23 16:48 [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp" Caleb Sander Mateos
2024-10-24 15:08 ` Simon Horman
@ 2024-10-24 16:51 ` Tariq Toukan
2024-10-25 4:12 ` Kalesh Anakkur Purayil
2024-10-30 0:29 ` Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Tariq Toukan @ 2024-10-24 16:51 UTC (permalink / raw)
To: Caleb Sander Mateos, Saeed Mahameed, Tariq Toukan,
Leon Romanovsky, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-rdma, linux-kernel
On 23/10/2024 19:48, Caleb Sander Mateos wrote:
> "enahnced" looks to be a misspelling of "enhanced".
Indeed.
> Rename "mlx5_cqwq_get_cqe_enahnced_comp" to
> "mlx5_cqwq_get_cqe_enhanced_comp".
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> ---
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp"
2024-10-23 16:48 [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp" Caleb Sander Mateos
2024-10-24 15:08 ` Simon Horman
2024-10-24 16:51 ` Tariq Toukan
@ 2024-10-25 4:12 ` Kalesh Anakkur Purayil
2024-10-30 0:29 ` Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Kalesh Anakkur Purayil @ 2024-10-25 4:12 UTC (permalink / raw)
To: Caleb Sander Mateos
Cc: Saeed Mahameed, Tariq Toukan, Leon Romanovsky, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Wed, Oct 23, 2024 at 10:19 PM Caleb Sander Mateos
<csander@purestorage.com> wrote:
>
> "enahnced" looks to be a misspelling of "enhanced".
> Rename "mlx5_cqwq_get_cqe_enahnced_comp" to
> "mlx5_cqwq_get_cqe_enhanced_comp".
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
--
Regards,
Kalesh A P
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp"
2024-10-23 16:48 [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp" Caleb Sander Mateos
` (2 preceding siblings ...)
2024-10-25 4:12 ` Kalesh Anakkur Purayil
@ 2024-10-30 0:29 ` Jakub Kicinski
3 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2024-10-30 0:29 UTC (permalink / raw)
To: Caleb Sander Mateos
Cc: Saeed Mahameed, Tariq Toukan, Leon Romanovsky, Andrew Lunn,
David S. Miller, Eric Dumazet, Paolo Abeni, netdev, linux-rdma,
linux-kernel
On Wed, 23 Oct 2024 10:48:38 -0600 Caleb Sander Mateos wrote:
> "enahnced" looks to be a misspelling of "enhanced".
> Rename "mlx5_cqwq_get_cqe_enahnced_comp" to
> "mlx5_cqwq_get_cqe_enhanced_comp".
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-30 0:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 16:48 [PATCH] mlx5: fix typo in "mlx5_cqwq_get_cqe_enahnced_comp" Caleb Sander Mateos
2024-10-24 15:08 ` Simon Horman
2024-10-24 16:51 ` Tariq Toukan
2024-10-25 4:12 ` Kalesh Anakkur Purayil
2024-10-30 0:29 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).