From: Simon Horman <horms@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Manish Chopra <manishc@marvell.com>,
Rahul Verma <rahulv@marvell.com>,
"supporter:NETXEN (1/10) GbE SUPPORT"
<GR-Linux-NIC-Dev@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shahed Shaikh <shshaikh@marvell.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: qlogic: use ethtool string helpers
Date: Fri, 25 Oct 2024 10:21:25 +0100 [thread overview]
Message-ID: <20241025092125.GK1202098@kernel.org> (raw)
In-Reply-To: <20241024195534.176410-1-rosenp@gmail.com>
On Thu, Oct 24, 2024 at 12:55:34PM -0700, Rosen Penev wrote:
> The latter is the preferred way to copy ethtool strings.
>
> Avoids manually incrementing the pointer. Cleans up the code quite well.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> .../qlogic/netxen/netxen_nic_ethtool.c | 14 ++---
> .../net/ethernet/qlogic/qede/qede_ethtool.c | 34 +++++------
> .../ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 60 +++++++++----------
I do suspect some of these drivers are quite old, and
we would be better off restricting changes to bug fixes
and updates for API changes, rather than cleaning them up.
That said, these changes do seem correct to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-25 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 19:55 [PATCH net-next] net: qlogic: use ethtool string helpers Rosen Penev
2024-10-25 9:21 ` Simon Horman [this message]
2024-10-29 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025092125.GK1202098@kernel.org \
--to=horms@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rahulv@marvell.com \
--cc=rosenp@gmail.com \
--cc=shshaikh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).