Re: [PATCH net-next] r8169: add support for RTL8125D

[Simon Horman <horms@kernel.org>]

On Fri, Oct 25, 2024 at 01:44:48PM +0200, Heiner Kallweit wrote:
> On 25.10.2024 13:25, Simon Horman wrote:
> > On Thu, Oct 24, 2024 at 10:42:33PM +0200, Heiner Kallweit wrote:
> >> This adds support for new chip version RTL8125D, which can be found on
> >> boards like Gigabyte X870E AORUS ELITE WIFI7. Firmware rtl8125d-1.fw
> >> for this chip version is available in linux-firmware already.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > 
> > Reviewed-by: Simon Horman <horms@kernel.org>
> > 
> > ...
> > 
> >> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> > 
> > ...
> > 
> >> @@ -3872,6 +3873,12 @@ static void rtl_hw_start_8125b(struct rtl8169_private *tp)
> >>  	rtl_hw_start_8125_common(tp);
> >>  }
> >>  
> >> +static void rtl_hw_start_8125d(struct rtl8169_private *tp)
> >> +{
> >> +	rtl_set_def_aspm_entry_latency(tp);
> >> +	rtl_hw_start_8125_common(tp);
> >> +}
> >> +
> >>  static void rtl_hw_start_8126a(struct rtl8169_private *tp)
> > 
> > Maybe as a follow-up, rtl_hw_start_8125d and rtl_hw_start_8126a could
> > be consolidated. They seem to be the same.
> > 
> Thanks for the review. Yes, for now they are the same. Both chip versions are new
> and once there are enough users, I wouldn't be surprised if we need version-specific
> tweaks to work around compatibility issues on certain systems.
> Therefore the separate versions for the time being.

Thanks, understood.