Re: [PATCH v1 6/9] hwmon: Add Nuvoton NCT6694 HWMON support

Guenter Roeck
2024-10-25T15:44:14Z

On 10/25/24 08:22, Ming Yu wrote:
[ ... ]

>>>> +static int nct6694_fan_write(struct device *dev, u32 attr, int channel,
>>>> + long val)
>>>> +{
>>>> + struct nct6694_hwmon_data *data = dev_get_drvdata(dev);
>>>> + unsigned char enable_buf[REQUEST_HWMON_CMD0_LEN] = {0};
>>> [Kalesh] Please try to maintain RCT order for variable declaration
>>
>> Ok, but that is already the case here ?
>
> [Ming] Is there anything that needs to be changed?
>

I don't think so, If two lines have the same length, the order is up
to the developer to decide.

Question though is if the buffer needs to be initialized. You should drop
the initialization if it is not necessary. In that case the second line
would be shorter anyway, and the order question would not arise.

Thanks,
Guenter