* [PATCH net-next v2] net: Use str_yes_no() helper function
@ 2024-10-26 15:28 Thorsten Blum
2024-10-28 20:03 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-10-26 15:28 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Willem de Bruijn, Gou Hao, Mina Almasry,
Abhishek Chauhan, Kuniyuki Iwashima
Cc: Thorsten Blum, netdev, linux-kernel
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
Changes in v2:
- Use str_yes_no() instead of str_no_yes() as suggested by Willem de Bruijn
- Link to v1: https://lore.kernel.org/r/20241026112946.129310-2-thorsten.blum@linux.dev/
---
net/core/sock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index 039be95c40cf..f753f87d0715 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -4140,7 +4140,7 @@ static long sock_prot_memory_allocated(struct proto *proto)
static const char *sock_prot_memory_pressure(struct proto *proto)
{
return proto->memory_pressure != NULL ?
- proto_memory_pressure(proto) ? "yes" : "no" : "NI";
+ str_yes_no(proto_memory_pressure(proto)) : "NI";
}
static void proto_seq_printf(struct seq_file *seq, struct proto *proto)
@@ -4154,7 +4154,7 @@ static void proto_seq_printf(struct seq_file *seq, struct proto *proto)
sock_prot_memory_allocated(proto),
sock_prot_memory_pressure(proto),
proto->max_header,
- proto->slab == NULL ? "no" : "yes",
+ str_yes_no(proto->slab),
module_name(proto->owner),
proto_method_implemented(proto->close),
proto_method_implemented(proto->connect),
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next v2] net: Use str_yes_no() helper function
2024-10-26 15:28 [PATCH net-next v2] net: Use str_yes_no() helper function Thorsten Blum
@ 2024-10-28 20:03 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2024-10-28 20:03 UTC (permalink / raw)
To: Thorsten Blum
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
Willem de Bruijn, Gou Hao, Mina Almasry, Abhishek Chauhan,
Kuniyuki Iwashima, netdev, linux-kernel
On Sat, 26 Oct 2024 17:28:46 +0200 Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
Same answer as for:
net: sched: etf: Use str_on_off() helper function in etf_init()
Use of the common string helpers is subjective.
Please try to avoid targeting networking with such cleanups.
--
pw-bot: reject
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-28 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-26 15:28 [PATCH net-next v2] net: Use str_yes_no() helper function Thorsten Blum
2024-10-28 20:03 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).